-
-
Notifications
You must be signed in to change notification settings - Fork 266
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: symfony/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.1.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: symfony/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.1.4
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 14 commits
- 7 files changed
- 4 contributors
Commits on Aug 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6d1d911 - Browse repository at this point
Copy the full SHA 6d1d911View commit details -
Configuration menu - View commit details
-
Copy full SHA for 32e3fbc - Browse repository at this point
Copy the full SHA 32e3fbcView commit details
Commits on Aug 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 6367c31 - Browse repository at this point
Copy the full SHA 6367c31View commit details -
minor #37773 Modernized deprecated PHPUnit assertion calls (derrabus)
This PR was squashed before being merged into the 3.4 branch. Discussion ---------- Modernized deprecated PHPUnit assertion calls | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Part of #37564 | License | MIT | Doc PR | N/A Some assertions have been renamed in PHPUnit 9. PhpUnitBridge should already have polyfills in place for those methods, so it should be save to use them. Commits ------- ab417f7040 Modernized deprecated PHPUnit assertion calls
Configuration menu - View commit details
-
Copy full SHA for 6ceb165 - Browse repository at this point
Copy the full SHA 6ceb165View commit details -
bug #37774 [Console] Make sure we pass a numeric array of arguments t…
…o call_user_func_array() (derrabus) This PR was merged into the 3.4 branch. Discussion ---------- [Console] Make sure we pass a numeric array of arguments to call_user_func_array() | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A On php 8, the unit tests fail with the following error: ``` ArgumentCountError: array_merge() does not accept unknown named parameters ``` This PR should fix the issue. Commits ------- 67102c32e6 [Console] Make sure we pass a numeric array of arguments to call_user_func_array().
Configuration menu - View commit details
-
Copy full SHA for 71da881 - Browse repository at this point
Copy the full SHA 71da881View commit details
Commits on Aug 10, 2020
-
* 3.4: Add Tagalog translations for validator messages 94, 95, 96 and 99 PHPUnit's assertContains() performs strict comparisons now. [ClassLoader][Routing] Fix namespace parsing on php 8. Fix deprecated libxml_disable_entity_loader Made reference to PHPUnit\Util\XML::loadfile php5-compatible. [Validator] Add missing translations for german and vietnamese Modernized deprecated PHPUnit assertion calls [Console] The message of "class not found" errors has changed in php 8. The PHPUnit\Util\XML class has been removed in PHPUnit 9.3. [Console] Make sure we pass a numeric array of arguments to call_user_func_array(). [Serializer] Fix that it will never reach DOMNode [Validator] sync translations [VarDumper] Improve previous fix on light array coloration [Cache] Fix #37667
Configuration menu - View commit details
-
Copy full SHA for 5630b52 - Browse repository at this point
Copy the full SHA 5630b52View commit details -
* 4.4: Fix typo Fix deprecated libxml_disable_entity_loader Add Tagalog translations for validator messages 94, 95, 96 and 99 PHPUnit's assertContains() performs strict comparisons now. [ClassLoader][Routing] Fix namespace parsing on php 8. Fix deprecated libxml_disable_entity_loader Made reference to PHPUnit\Util\XML::loadfile php5-compatible. [Validator] Add missing translations for german and vietnamese Modernized deprecated PHPUnit assertion calls [Console] The message of "class not found" errors has changed in php 8. The PHPUnit\Util\XML class has been removed in PHPUnit 9.3. [Console] Make sure we pass a numeric array of arguments to call_user_func_array(). [Serializer] Fix that it will never reach DOMNode [Validator] sync translations [VarDumper] Improve previous fix on light array coloration [Cache] Fix #37667
Configuration menu - View commit details
-
Copy full SHA for 57adf18 - Browse repository at this point
Copy the full SHA 57adf18View commit details
Commits on Aug 11, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a5551ef - Browse repository at this point
Copy the full SHA a5551efView commit details -
bug #37731 [Console] Table: support cells with newlines after a cell …
…with colspan >= 2 (GMTA) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Console] Table: support cells with newlines after a cell with colspan >= 2 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A When rendering a table with a cell containing newlines after a cell with colspan set to at least 2, every line in the cell with newlines except the first one fails to render. This case is fixed by calling `->fillCells()` on the unmerged rows and implementing support for rows that start with a non-zero index for the columns. While fixing this, I discovered another issue with colspan: if a cell following a colspanned cell contains enough newlines to make the contents extend further than the colspanned cell's contents, the cells become misaligned. This is now also fixed. Commits ------- ca11772e3f [Console] Table: support cells with newlines after a cell with colspan >= 2
Configuration menu - View commit details
-
Copy full SHA for 81543eb - Browse repository at this point
Copy the full SHA 81543ebView commit details -
Revert changes to Table->fillCells()
These changes were introduced in symfony/symfony#37731 but no longer contributed to the actual fix, which was to perform a ->copyRow().
Jelle Raaijmakers committedAug 11, 2020 Configuration menu - View commit details
-
Copy full SHA for 8b40d65 - Browse repository at this point
Copy the full SHA 8b40d65View commit details
Commits on Aug 12, 2020
-
* 4.4: Fix for issue #37681 Revert changes to Table->fillCells() [Console] Table: support cells with newlines after a cell with colspan >= 2 Fix redis connect with empty password [Validator] Add BC layer for notInRangeMessage when min and max are set
Configuration menu - View commit details
-
Copy full SHA for d30cb85 - Browse repository at this point
Copy the full SHA d30cb85View commit details
Commits on Aug 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 1f601a2 - Browse repository at this point
Copy the full SHA 1f601a2View commit details -
* 4.4: Fix CS Fix CS [Validator] Add Polish translation for ISIN constraint
Configuration menu - View commit details
-
Copy full SHA for dbe3ef9 - Browse repository at this point
Copy the full SHA dbe3ef9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51ff337 - Browse repository at this point
Copy the full SHA 51ff337View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v5.1.3...v5.1.4