Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.2.2
Choose a base ref
...
head repository: symfony/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.2.3
Choose a head ref
  • 4 commits
  • 2 files changed
  • 3 contributors

Commits on Jan 21, 2021

  1. Fix console logger according to PSR-3

    @alex-dev
    alex-dev committed Jan 21, 2021
    Configuration menu
    Copy the full SHA
    86b9e48 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Use createMock() instead of a getter

    @OskarStark @chalasr
    OskarStark authored and chalasr committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    a5e89d5 View commit details
    Browse the repository at this point in the history

  2. minor #39920 [Console] Fix console logger according to PSR-3 (alex-dev) 

    This PR was merged into the 4.4 branch.

Discussion
----------

[Console] Fix console logger according to PSR-3

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39050, #29138
| License       | MIT

`Symfony\Component\HttpKernel\EventListener\ErrorListener` logs non-HTTP exceptions at `LogLevel::CRITICAL`.
`Symfony\Component\Messenger\Worker` logs unrecoverable exceptions at `LogLevel::CRITICAL`.
`Symfony\Component\Console\EventListener\ErrorListener` logs exceptions at `LogLevel::ERROR`.

As per PSR-3, unexpected and unrecoverable exceptions should be logged at `LogLevel::CRITICAL`.

Commits
-------

69fcd075eb Fix console logger according to PSR-3
    @jderusse
    jderusse committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    1a9570e View commit details
    Browse the repository at this point in the history

  3. Merge branch '4.4' into 5.2 

    * 4.4:
  Use createMock() instead of a getter
  [ErrorHandler] Fix strpos error when trying to call a method without a name
  use proper keys to not override appended files
  Fix console logger according to PSR-3
    @jderusse
    jderusse committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    89d4b17 View commit details
    Browse the repository at this point in the history
Loading