feat: Reduce caught exceptions in prettyDom (#1321)

Co-authored-by: David Rieman <[email protected]>

Author: DavidRieman

src/pretty-dom.js

@@ -5,25 +5,27 @@ import {getDocument} from './helpers'
 import {getConfig} from './config'
 
 const shouldHighlight = () => {
-  let colors
-  try {
-    colors = JSON.parse(process?.env?.COLORS)
-  } catch (e) {
-    // If this throws, process?.env?.COLORS wasn't parsable. Since we only
-    // care about `true` or `false`, we can safely ignore the error.
+  if (typeof process === 'undefined') {
+    // Don't colorize in non-node environments (e.g. Browsers)
+    return false
   }
-
-  if (typeof colors === 'boolean') {
-    // If `colors` is set explicitly (both `true` and `false`), use that value.
-    return colors
-  } else {
+  // Try to safely parse env COLORS: We will default behavior if any step fails.
+  try {
+    const colors = process.env?.COLORS
+    if (colors) {
+      const b = JSON.parse(colors)
+      if (typeof b === 'boolean') {
+        return b
+      }
+    }
+  } catch {
     // If `colors` is not set, colorize if we're in node.
-    return (
-      typeof process !== 'undefined' &&
-      process.versions !== undefined &&
-      process.versions.node !== undefined
-    )
+    return process.versions !== undefined && process.versions.node !== undefined
   }
+
+  // In all other cases, whether COLORS was a weird type, or the attempt threw:
+  // Fall back to colorizing if we are running in node.
+  return !!process?.versions?.node
 }
 
 const {DOMCollection} = prettyFormat.plugins