chore: Convert helpers.js to TypeScript
#1156
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d971798:
|
| "plugin:import/typescript" | ||
| ], | ||
| "rules": { | ||
| "@typescript-eslint/prefer-optional-chain": "off", |
There was a problem hiding this comment.
Stylistic rule whose rational is not suitable for a lint rule (false-positive rate needs to be next to zero).
| ], | ||
| "rules": { | ||
| "@typescript-eslint/prefer-optional-chain": "off", | ||
| "@typescript-eslint/no-explicit-any": "off", |
There was a problem hiding this comment.
Typed languages have won over JS because we have these escape hatches. They're still relevant especially in a library
| "rules": { | ||
| "@typescript-eslint/prefer-optional-chain": "off", | ||
| "@typescript-eslint/no-explicit-any": "off", | ||
| "@typescript-eslint/no-unsafe-member-access": "off", |
There was a problem hiding this comment.
Once this rule can distiginguish between explicit any and implicit/external any we can disable. Until then its false-positive rate is too high.
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 990 990
Branches 322 322
=========================================
Hits 990 990
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
🎉 This PR is included in version 8.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
What:
Part of #494
Why:
To use generated TypeScript declaration files eventually
How:
Fairly low level helpers where most types are
unknown. Usesanyfor pragmatic reasons.Checklist:
docs site