Feature/vimeo tag #409
Feature/vimeo tag #409
Conversation
|
|
|
Hell yeah, great contribution Josh. Will merge tomorrow assuming it looks good everywhere. |
| # My test suite isn't entirely passing, and I've spent longer on this than I | ||
| # wanted to, io Instead of looking into those, I'm going to just make this work ¯\_(ツ)_/¯ | ||
| it "accepts urls that were over-eagerly turned into links by markdown" do | ||
| assert_parses id, "<a href=\"https://vimeo.com/#{id}\">https://vimeo.com/192819855</a> " |
There was a problem hiding this comment.
Yeah, I guess with other ones, we sort of hack around this with some.
Markdown parsing should ignore the contents of liquid tags. But since this works the same as the other hacks, we're good to go for this, and the fix is to not autolink the contents of liquid tags.
|
I looked at the markdown gem to see if it could be extended to understand liquid syntax, but it seemed pretty difficult (they init everything in a function in C, which didn't seem to be extensible). What happens if we run liquid before markdown? |
|
@JoshCheek liquid currently runs after markdown so it can include tags that are not whitelisted in the markdown (like iframes and scripts). |
What type of PR is this? (check all applicable)
Description
There is a tag to render youtube videos (link). But I host on vimeo. This adds an equivalent Vimeo tag.
Note that dropping a vimeo url into it will work also, but there's a wonky thing where the markdown parser turns it into an anchor tag.
Related Tickets & Documents
YoutubeTag's source (link)YoutubeTag's spec (link)Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Here I change a post's body to have a vimeo tag in it:
Here is what it looks like rendered:
I haven't looked at it on my phone, but it uses the same dimensions as the YouTube tag, so if that one looks fine, this one should as well.
Added to documentation?