From 61ddee9ce70e070264d6031298f6083ed99ec892 Mon Sep 17 00:00:00 2001 From: Mithun Kamath Date: Tue, 10 Nov 2020 19:51:58 +0530 Subject: [PATCH] Fix issue where MM scorer reviews were not having tests passed info in the leaderboard --- src/services/LeaderboardService.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/services/LeaderboardService.js b/src/services/LeaderboardService.js index ce0075c..3b58fa0 100644 --- a/src/services/LeaderboardService.js +++ b/src/services/LeaderboardService.js @@ -32,7 +32,8 @@ async function getLeaderboard (challengeId, memberId) { function getTestsPassed (metadata) { const tests = metadata.tests || { total: 0, pending: 0, failed: 0 } - let testsPassed = tests.total - tests.pending - tests.failed + // MM scorer has passed tests count in the review already. Use it directly if it exists + let testsPassed = tests.passed ? tests.passed : (tests.total - tests.pending - tests.failed) if (!testsPassed) { testsPassed = 0