Skip to content

[$20] Remove support of enrich query param for GET /taas-teams/me endpoint #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
maxceem opened this issue Mar 3, 2021 · 6 comments
Closed

Comments

@maxceem
Copy link
Contributor

maxceem commented Mar 3, 2021

We found an issue with using enrich query param of GET /taas-teams/me?enrich= endpoint, see #154 (comment).

So we have to remove support of enrich for the GET /taas-teams/me endpoint. And we always have to get user data from u-bahn with enrich=true.

  • remove the support of enrich query param from API, Swagger, Postman, Joi, and so on.
  • we have to always get data from u-bahn with enrich=true if we filter by externalProfile.externalId
@maxceem
Copy link
Contributor Author

maxceem commented Mar 3, 2021

Challenge https://www.topcoder.com/challenges/3fe7d3a3-c9de-4252-b766-f162ebc687bb has been created for this ticket.

This is an automated message for maxceem via Topcoder X

@maxceem maxceem changed the title [$15] Remove support of enrich query param for GET /taas-teams/me endpoint [$15] Remove support of enrich query param for GET /taas-teams/me endpoint Mar 3, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Mar 3, 2021

@imcaizheng would you like to pick up this?

@maxceem maxceem added this to the v1.5.1 - Post Release Bugfix milestone Mar 3, 2021
@maxceem maxceem changed the title [$15] Remove support of enrich query param for GET /taas-teams/me endpoint [$20] Remove support of enrich query param for GET /taas-teams/me endpoint Mar 3, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Mar 3, 2021

@imcaizheng I had to revert PR for adding me endpoint #161 by this PR #171. Because we need to keep dev branch fully workable now.

You can revert my revert again in your branch and after update it as per this issue description. I hope it's not confusing.

@imcaizheng imcaizheng self-assigned this Mar 3, 2021
@maxceem
Copy link
Contributor Author

maxceem commented Mar 3, 2021

Challenge https://www.topcoder.com/challenges/3fe7d3a3-c9de-4252-b766-f162ebc687bb has been assigned to aaron2017.

This is an automated message for maxceem via Topcoder X

@imcaizheng
Copy link
Contributor

@maxceem Here is a new PR #172

@maxceem
Copy link
Contributor Author

maxceem commented Mar 12, 2021

Payment task has been updated: https://www.topcoder.com/challenges/3fe7d3a3-c9de-4252-b766-f162ebc687bb
Payments Complete
Winner: aaron2017
Copilot: maxceem
Challenge 3fe7d3a3-c9de-4252-b766-f162ebc687bb has been paid and closed.

This is an automated message for maxceem via Topcoder X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants