Skip to content

[50$] Eslint errors #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gondzo opened this issue Dec 21, 2016 · 8 comments
Closed

[50$] Eslint errors #8

gondzo opened this issue Dec 21, 2016 · 8 comments
Assignees

Comments

@gondzo
Copy link
Contributor

gondzo commented Dec 21, 2016

Running eslint produces 900+ errors that should be fixed.

@lstkz
Copy link
Collaborator

lstkz commented Dec 22, 2016

please assign to me

handle: Sky_

@lstkz
Copy link
Collaborator

lstkz commented Dec 22, 2016

see #9

@lstkz
Copy link
Collaborator

lstkz commented Dec 22, 2016

btw there are many duplicated components under different routes

@lstkz
Copy link
Collaborator

lstkz commented Dec 22, 2016

I would suggest merging eslint fixes to other branches, before doing any new contests.
Otherwise, branch merges will be hard.

@gondzo
Copy link
Contributor Author

gondzo commented Dec 22, 2016

With the updated eslintrc I get many 'Parse errors in imported module './XXYY.scss' import/no-named-as-default'. Adding '"settings":{"import/ignore":[".scss$"] }"' to eslintrc is correct ?
Also, there are 132 'import/no-named-as-default' errors like
'Using exported name 'StatusDetailView' as identifier for default export import/no-named-as-default'

@lstkz
Copy link
Collaborator

lstkz commented Dec 22, 2016

can you remove node_modules and rerun npm i?

@gondzo
Copy link
Contributor Author

gondzo commented Dec 22, 2016

That does it. Running lint fix to resolve line ending issues produces the above errors.
Closing the issue.

@kbowerma
Copy link
Contributor

kbowerma commented Feb 1, 2017

Jira Payment record: https://apps.topcoder.com/bugs/browse/DRONESERIES-9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants