Merge pull request microsoft#21649 from Microsoft/conditionalTypesASI

Conditional types ASI

Author: ahejlsberg

src/compiler/parser.ts

@@ -2986,7 +2986,7 @@ namespace ts {
                 return parseFunctionOrConstructorType(SyntaxKind.ConstructorType);
             }
             const type = parseUnionTypeOrHigher();
-            if (!noConditionalTypes && parseOptional(SyntaxKind.ExtendsKeyword)) {
+            if (!noConditionalTypes && !scanner.hasPrecedingLineBreak() && parseOptional(SyntaxKind.ExtendsKeyword)) {
                 const node = <ConditionalTypeNode>createNode(SyntaxKind.ConditionalType, type.pos);
                 node.checkType = type;
                 // The type following 'extends' is not permitted to be another conditional type

tests/baselines/reference/conditionalTypesASI.js

@@ -0,0 +1,18 @@
+//// [conditionalTypesASI.ts]
+// Repro from #21637
+
+interface JSONSchema4 {
+  a?: number
+  extends?: string | string[]
+}
+
+
+//// [conditionalTypesASI.js]
+// Repro from #21637
+
+
+//// [conditionalTypesASI.d.ts]
+interface JSONSchema4 {
+    a?: number;
+    extends?: string | string[];
+}

tests/baselines/reference/conditionalTypesASI.symbols

@@ -0,0 +1,13 @@
+=== tests/cases/compiler/conditionalTypesASI.ts ===
+// Repro from #21637
+
+interface JSONSchema4 {
+>JSONSchema4 : Symbol(JSONSchema4, Decl(conditionalTypesASI.ts, 0, 0))
+
+  a?: number
+>a : Symbol(JSONSchema4.a, Decl(conditionalTypesASI.ts, 2, 23))
+
+  extends?: string | string[]
+>extends : Symbol(JSONSchema4.extends, Decl(conditionalTypesASI.ts, 3, 12))
+}
+

tests/baselines/reference/conditionalTypesASI.types

@@ -0,0 +1,13 @@
+=== tests/cases/compiler/conditionalTypesASI.ts ===
+// Repro from #21637
+
+interface JSONSchema4 {
+>JSONSchema4 : JSONSchema4
+
+  a?: number
+>a : number
+
+  extends?: string | string[]
+>extends : string | string[]
+}
+

tests/cases/compiler/conditionalTypesASI.ts

@@ -0,0 +1,8 @@
+// @declaration: true
+
+// Repro from #21637
+
+interface JSONSchema4 {
+  a?: number
+  extends?: string | string[]
+}