Skip to content

Commit 652e493

Browse files
committed
Address CR feedback
1 parent b38e42e commit 652e493

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/compiler/checker.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5629,7 +5629,7 @@ namespace ts {
56295629
* @param lateSymbols The late-bound symbols of the parent.
56305630
* @param decl The member to bind.
56315631
*/
5632-
function lateBindMember(parent: Symbol, earlySymbols: SymbolTable | undefined, lateSymbols: UnderscoreEscapedMap<TransientSymbol>, decl: LateBoundDeclaration) {
5632+
function lateBindMember(parent: Symbol, earlySymbols: SymbolTable | undefined, lateSymbols: SymbolTable, decl: LateBoundDeclaration) {
56335633
Debug.assert(!!decl.symbol, "The member is expected to have a symbol.");
56345634
const links = getNodeLinks(decl);
56355635
if (!links.resolvedSymbol) {
@@ -5686,7 +5686,7 @@ namespace ts {
56865686
links[resolutionKind] = earlySymbols || emptySymbols;
56875687

56885688
// fill in any as-yet-unresolved late-bound members.
5689-
const lateSymbols = createMap() as UnderscoreEscapedMap<TransientSymbol>;
5689+
const lateSymbols = createSymbolTable();
56905690
for (const decl of symbol.declarations) {
56915691
const members = getMembersOfDeclaration(decl);
56925692
if (members) {
@@ -6606,8 +6606,8 @@ namespace ts {
66066606
}
66076607
else {
66086608
if (type !== commonType) {
6609-
checkFlags |= CheckFlags.HasNonUniformType;
6610-
}
6609+
checkFlags |= CheckFlags.HasNonUniformType;
6610+
}
66116611
}
66126612
propTypes.push(type);
66136613
}

src/compiler/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3369,11 +3369,11 @@ namespace ts {
33693369
members?: SymbolTable; // Class, interface or object literal instance members
33703370
exports?: SymbolTable; // Module exports
33713371
globalExports?: SymbolTable; // Conditional global UMD exports
3372-
nameType?: Type; // Type associated with a late-bound symbol
33733372
/* @internal */ id?: number; // Unique id (used to look up SymbolLinks)
33743373
/* @internal */ mergeId?: number; // Merge id (used to look up merged symbol)
33753374
/* @internal */ parent?: Symbol; // Parent symbol
33763375
/* @internal */ exportSymbol?: Symbol; // Exported symbol associated with this symbol
3376+
/* @internal */ nameType?: Type; // Type associated with a late-bound symbol
33773377
/* @internal */ constEnumOnlyModule?: boolean; // True if module contains only const enums or other modules with only const enums
33783378
/* @internal */ isReferenced?: SymbolFlags; // True if the symbol is referenced elsewhere. Keeps track of the meaning of a reference in case a symbol is both a type parameter and parameter.
33793379
/* @internal */ isReplaceableByMethod?: boolean; // Can this Javascript class property be replaced by a method symbol?

0 commit comments

Comments
 (0)