Skip to content

Commit 45f7132

Browse files
committed
fix: all codepaths should return a value
1 parent 08a2dc6 commit 45f7132

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

packages/uui-file-dropzone/lib/uui-file-dropzone.element.ts

+13-12
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ export class UUIFileDropzoneElement extends LabelMixin('', LitElement) {
133133
}
134134

135135
private async _getAllFileEntries(
136-
dataTransferItemList: DataTransferItemList,
136+
dataTransferItemList: DataTransferItemList
137137
): Promise<File[]> {
138138
const fileEntries: File[] = [];
139139
// Use BFS to traverse entire directory/file structure
@@ -152,7 +152,7 @@ export class UUIFileDropzoneElement extends LabelMixin('', LitElement) {
152152
if ('webkitGetAsEntry' in entry === false) continue;
153153
const directory = entry.webkitGetAsEntry()! as FileSystemDirectoryEntry;
154154
queue.push(
155-
...(await this._readAllDirectoryEntries(directory.createReader())),
155+
...(await this._readAllDirectoryEntries(directory.createReader()))
156156
);
157157
}
158158
}
@@ -163,7 +163,7 @@ export class UUIFileDropzoneElement extends LabelMixin('', LitElement) {
163163
// Get all the entries (files or sub-directories) in a directory
164164
// by calling readEntries until it returns empty array
165165
private async _readAllDirectoryEntries(
166-
directoryReader: FileSystemDirectoryReader,
166+
directoryReader: FileSystemDirectoryReader
167167
) {
168168
const entries: any = [];
169169
let readEntries: any = await this._readEntriesPromise(directoryReader);
@@ -175,15 +175,16 @@ export class UUIFileDropzoneElement extends LabelMixin('', LitElement) {
175175
}
176176

177177
private async _readEntriesPromise(
178-
directoryReader: FileSystemDirectoryReader,
178+
directoryReader: FileSystemDirectoryReader
179179
) {
180-
try {
181-
return await new Promise((resolve, reject) => {
180+
return new Promise((resolve, reject) => {
181+
try {
182182
directoryReader.readEntries(resolve, reject);
183-
});
184-
} catch (err) {
185-
console.log(err);
186-
}
183+
} catch (err) {
184+
console.log(err);
185+
reject(err);
186+
}
187+
});
187188
}
188189

189190
private _isAccepted(file: File) {
@@ -234,7 +235,7 @@ export class UUIFileDropzoneElement extends LabelMixin('', LitElement) {
234235
this.dispatchEvent(
235236
new UUIFileDropzoneEvent(UUIFileDropzoneEvent.CHANGE, {
236237
detail: { files: result },
237-
}),
238+
})
238239
);
239240
}
240241
}
@@ -260,7 +261,7 @@ export class UUIFileDropzoneElement extends LabelMixin('', LitElement) {
260261
this.dispatchEvent(
261262
new UUIFileDropzoneEvent(UUIFileDropzoneEvent.CHANGE, {
262263
detail: { files: files },
263-
}),
264+
})
264265
);
265266
}
266267

0 commit comments

Comments
 (0)