Skip to content

Allow uui-button to fit in less tall contexts #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2022
Merged

Allow uui-button to fit in less tall contexts #236

merged 2 commits into from
Jun 22, 2022

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Jun 22, 2022 •
edited
Loading

By removing top and bottom padding, content always stays vertically aligned.
This make it simpler to implement, and there by only require implementors to set --uui-button-height, to squeeze the button height.

Fixes #227

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
    Co-authored-by: Niels Lyngsø [email protected]

@nielslyngsoe nielslyngsoe requested a review from iOvergaard June 22, 2022 10:09
@iOvergaard iOvergaard changed the title Make button fit in less tall contexts Allow uui-button to fit in less tall contexts Jun 22, 2022
@iOvergaard iOvergaard merged commit 8b7422f into v1/dev Jun 22, 2022
@iOvergaard iOvergaard deleted the v1/bugfix/input-append-button-height branch June 22, 2022 10:37
@nielslyngsoe nielslyngsoe mentioned this pull request Jun 22, 2022
Closed
@iOvergaard iOvergaard added the bug Something isn't working label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielslyngsoe @iOvergaard