Skip to content

fix(uui-dialog): Remove native dialog background #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

JesmoDev
Copy link
Contributor

The background of the dialog would occasionally appear in the corners of a rounded edge. This update removes the redundant background on the native dialog, as the uui-dialog already includes a background.

Before:
image

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

It hurts my eyes

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-781.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Apr 11, 2024
@iOvergaard iOvergaard changed the title Remove native dialog background in uui-dialog fix(uui-dialog): Remove native dialog background Apr 11, 2024
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-781.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit 13fd470 into v1/contrib Apr 11, 2024
10 of 11 checks passed
@iOvergaard iOvergaard deleted the bugfix/dialog-background branch April 11, 2024 07:58
@JesmoDev JesmoDev mentioned this pull request Apr 15, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants