-
-
Notifications
You must be signed in to change notification settings - Fork 69
Bump Swift minimum to 6.0 #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #275 +/- ##
==========================================
+ Coverage 42.47% 43.05% +0.57%
==========================================
Files 13 13
Lines 871 871
==========================================
+ Hits 370 375 +5
+ Misses 501 496 -5
🚀 New features to boost your workflow:
|
…others aren't honoring it
| - postgres:13 | ||
| - postgres:18 | ||
| - postgres:16 | ||
| - postgres:14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep pg 13 I'd say, as long as Postgres themselves are supporting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were no protocol changes between 13 and 14, so I see no point in making the test matrix even larger; it doesn't actually tell you anything that the test for 14 doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasnt thinking about a larger matrix. Mostly just replacing 14 with 13
These changes are now available in 2.15.0
Also update CI and convert the tests to SwiftTesting.