Skip to content

Commit 100c5c6

Browse files
committed
feat: complete prettier integration
1 parent 6e29daa commit 100c5c6

File tree

5 files changed

+27
-14
lines changed

5 files changed

+27
-14
lines changed

packages/@vue/cli-plugin-eslint/__tests__/eslintGenerator.spec.js

+17-4
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,23 @@ test('standard', async () => {
4848
expect(pkg.devDependencies).toHaveProperty('@vue/eslint-config-standard')
4949
})
5050

51+
test('prettier', async () => {
52+
const { pkg } = await generateWithPlugin({
53+
id: 'eslint',
54+
apply: require('../generator'),
55+
options: {
56+
config: 'prettier'
57+
}
58+
})
59+
60+
expect(pkg.scripts.lint).toBeTruthy()
61+
expect(pkg.eslintConfig).toEqual({
62+
extends: ['plugin:vue/essential', '@vue/prettier']
63+
})
64+
expect(pkg.devDependencies).toHaveProperty('eslint-plugin-vue')
65+
expect(pkg.devDependencies).toHaveProperty('@vue/eslint-config-prettier')
66+
})
67+
5168
test('lint on save', async () => {
5269
const { pkg } = await generateWithPlugin({
5370
id: 'eslint',
@@ -77,7 +94,3 @@ test('lint on commit', async () => {
7794
'*.vue': ['vue-cli-service lint', 'git add']
7895
})
7996
})
80-
81-
test('prettier', async () => {
82-
// TODO
83-
})

packages/@vue/cli/lib/promptModules/linter.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ module.exports = cli => {
3131
name: 'ESLint + Standard config',
3232
value: 'standard',
3333
short: 'Standard'
34+
},
35+
{
36+
name: 'ESLint + Prettier',
37+
value: 'prettier',
38+
short: 'Prettier'
3439
}
35-
// {
36-
// name: 'ESLint + Prettier',
37-
// value: 'prettier',
38-
// short: 'Prettier'
39-
// }
4040
]
4141
})
4242

packages/@vue/eslint-config-prettier/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ module.exports = {
44
require.resolve('eslint-config-prettier')
55
],
66
rules: {
7-
'prettier/prettier': 'error'
7+
'prettier/prettier': 'warn'
88
}
99
}

packages/@vue/eslint-config-prettier/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"homepage": "https://github.com/vuejs/vue-cli/packages/@vue/eslint-config-prettier#readme",
2323
"dependencies": {
2424
"eslint-config-prettier": "^2.9.0",
25-
"eslint-plugin-prettier": "^2.4.0",
25+
"eslint-plugin-prettier": "^2.5.0",
2626
"prettier": "^1.10.2"
2727
}
2828
}

yarn.lock

+3-3
Original file line numberDiff line numberDiff line change
@@ -3221,9 +3221,9 @@ eslint-plugin-node@^5.2.1:
32213221
resolve "^1.3.3"
32223222
semver "5.3.0"
32233223

3224-
eslint-plugin-prettier@^2.4.0:
3225-
version "2.4.0"
3226-
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-2.%3Cspan%20class="x x-first x-last">4.0.tgz#85cab0775c6d5e3344ef01e78d960f166fb93aae"
3224+
eslint-plugin-prettier@^2.5.0:
3225+
version "2.5.0"
3226+
resolved "https://registry.yarnpkg.com/eslint-plugin-prettier/-/eslint-plugin-prettier-2.%3Cspan%20class="x x-first x-last">5.0.tgz#39a91dd7528eaf19cd42c0ee3f2c1f684606a05f"
32273227
dependencies:
32283228
fast-diff "^1.1.1"
32293229
jest-docblock "^21.0.0"

0 commit comments

Comments
 (0)