Skip to content

Commit 87ddfc6

Browse files
authored
Merge pull request AlexDisler#114 from gregvis/master
added android version detection to automatically adjust output folder
2 parents 612490e + 3bbc773 commit 87ddfc6

File tree

3 files changed

+20
-1
lines changed

3 files changed

+20
-1
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,4 @@ build/Release
2626
# Deployed apps should consider commenting this line out:
2727
# see https://npmjs.org/doc/faq.html#Should-I-check-my-node_modules-folder-into-git
2828
node_modules
29+
yarn.lock

index.js

Lines changed: 18 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ var colors = require('colors');
66
var _ = require('underscore');
77
var Q = require('q');
88
var argv = require('minimist')(process.argv.slice(2));
9+
var semver = require('semver');
910

1011
/**
1112
* @var {Object} settings - names of the config file and of the icon image
@@ -15,6 +16,22 @@ settings.CONFIG_FILE = argv.config || 'config.xml';
1516
settings.ICON_FILE = argv.icon || 'icon.png';
1617
settings.OLD_XCODE_PATH = argv['xcode-old'] || false;
1718

19+
20+
/**
21+
* Get Android Folder based on Android Platform version
22+
*/
23+
var getAndroidFolder = function(){
24+
var androidFolder = 'platforms/android/app/src/main/res/'; //as of cordova-android@7.0.0
25+
if(!fs.existsSync('platforms/android/cordova/version')){
26+
return androidFolder;
27+
}
28+
if(semver.lt(require('../../platforms/android/cordova/version').version, '7.0.0')){
29+
androidFolder = 'platforms/android/res/';
30+
}
31+
return androidFolder;
32+
}
33+
34+
1835
/**
1936
* Check which platforms are added to the project and return their icon names and sizes
2037
*
@@ -69,7 +86,7 @@ var getPlatforms = function (projectName) {
6986
platforms.push({
7087
name : 'android',
7188
isAdded : fs.existsSync('platforms/android'),
72-
iconsPath : 'platforms/android/res/',
89+
iconsPath : getAndroidFolder(),
7390
icons : [
7491
{ name : 'drawable/icon.png', size : 96 },
7592
{ name : 'drawable-hdpi/icon.png', size : 72 },

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"imagemagick": "^0.1.3",
3232
"minimist": "^1.2.0",
3333
"q": "^1.0.1",
34+
"semver": "^5.5.0",
3435
"underscore": "^1.6.0",
3536
"xml2js": "^0.4.3"
3637
}

0 commit comments

Comments
 (0)