Extend create groups

Author: lifeofguenter

lib/Gitlab/Api/Groups.php

@@ -67,16 +67,26 @@ public function show($id)
      * @param string $path
      * @param string $description
      * @param string $visibility
+     * @param bool   $lfs_enabled
+     * @param bool   $request_access_enabled
+     * @param int    $parent_id
+     * @param int    $shared_runners_minutes_limit
      * @return mixed
      */
-    public function create($name, $path, $description = null, $visibility = 'private')
+    public function create($name, $path, $description = null, $visibility = 'private', $lfs_enabled = null, $request_access_enabled = null, $parent_id = null, $shared_runners_minutes_limit = null)
     {
-        return $this->post('groups', array(
+        $params = array(
             'name' => $name,
             'path' => $path,
             'description' => $description,
             'visibility' => $visibility,
-        ));
+            'lfs_enabled' => $lfs_enabled,
+            'request_access_enabled' => $request_access_enabled,
+            'parent_id' => $parent_id,
+            'shared_runners_minutes_limit' => $shared_runners_minutes_limit,
+        );
+
+        return $this->post('groups', array_filter($params, 'strlen'));
     }
 
     /**

test/Gitlab/Tests/Api/GroupsTest.php

@@ -111,7 +111,7 @@ public function shouldCreateGroup()
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('post')
-            ->with('groups', array('name' => 'A new group', 'path' => 'a-new-group', 'description' => null, 'visibility' => 'private'))
+            ->with('groups', array('name' => 'A new group', 'path' => 'a-new-group', 'visibility' => 'private'))
             ->will($this->returnValue($expectedArray))
         ;
 
@@ -121,17 +121,34 @@ public function shouldCreateGroup()
     /**
      * @test
      */
-    public function shouldCreateGroupWithDescriptionAndVisibility()
+    public function shouldCreateGroupWithDescriptionVisibilityAndParentId()
     {
-        $expectedArray = array('id' => 1, 'name' => 'A new group', 'visibility_level' => 2);
+        $expectedArray = array('id' => 1, 'name' => 'A new group', 'visibility_level' => 2, 'parent_id' => 666);
 
         $api = $this->getApiMock();
         $api->expects($this->once())
             ->method('post')
-            ->with('groups', array('name' => 'A new group', 'path' => 'a-new-group', 'description' => 'Description', 'visibility' => 'public'))
+            ->with('groups', array('name' => 'A new group', 'path' => 'a-new-group', 'description' => 'Description', 'visibility' => 'public', 'parent_id' => 666))
             ->will($this->returnValue($expectedArray))
         ;
 
+        $this->assertEquals($expectedArray, $api->create('A new group', 'a-new-group', 'Description', 'public', null, null, 666));
+    }
+
+    /**
+     * @test
+     */
+    public function shouldCreateGroupWithDescriptionAndVisibility()
+    {
+        $expectedArray = array('id' => 1, 'name' => 'A new group', 'visibility_level' => 2);
+
+        $api = $this->getApiMock();
+        $api->expects($this->once())
+        ->method('post')
+        ->with('groups', array('name' => 'A new group', 'path' => 'a-new-group', 'description' => 'Description', 'visibility' => 'public'))
+        ->will($this->returnValue($expectedArray))
+        ;
+
         $this->assertEquals($expectedArray, $api->create('A new group', 'a-new-group', 'Description', 'public'));
     }