Skip to content

Add operator deployment readiness probe #1874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2023
Merged

Add operator deployment readiness probe #1874

merged 2 commits into from
Jan 5, 2023

Conversation

@dmvolod
Copy link
Contributor

@dmvolod dmvolod commented Apr 29, 2022 •
edited
Loading

Fixes #1871

@dmvolod dmvolod changed the title WIP: Add operator deployment liveness and readiness probes Add operator deployment liveness and readiness probes Apr 29, 2022
@FxKu FxKu mentioned this pull request Apr 29, 2022
Merged
@dmvolod
Copy link
Contributor Author

dmvolod commented May 16, 2022

@FxKu could you please to have a look at this issue and possibility to fit it into 1.8.x or 1.9 release
Thanks in advance

@dmvolod dmvolod requested a review from idanovinda as a code owner May 18, 2022 06:04
@FxKu FxKu added this to the 1.9 milestone May 19, 2022
@FxKu
Copy link
Member

FxKu commented May 19, 2022 •
edited
Loading

At Zalando we consider liveness probes as something to avoid. The readiness probe might a good addition, though.

@dmvolod
Copy link
Contributor Author

dmvolod commented May 19, 2022 •
edited
Loading

At Zalando we consider liveness probes as something to avoid. The readiness probe might a good addition, though.

Good point, thanks. Will adopt it to utilize readiness probe only.

@dmvolod dmvolod changed the title Add operator deployment liveness and readiness probes Add operator deployment readiness probes May 20, 2022
@dmvolod dmvolod changed the title Add operator deployment readiness probes Add operator deployment readiness probe May 20, 2022
FxKu
FxKu reviewed Jan 5, 2023
View reviewed changes
pkg/controller/controller.go Outdated
go c.runPostgresTeamInformer(stopCh, wg)
}

go c.apiserver.Run(stopCh, wg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed to move this line further down. We have talked about it before, haven't we?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, seems to we don't need to modify this sequence, as API server should be running as latest go-routine, but it's not implemented. Changes reverted

@dmvolod dmvolod requested a review from hughcapet as a code owner January 5, 2023 11:53
@FxKu
Copy link
Member

FxKu commented Jan 5, 2023

👍

1 similar comment
@idanovinda
Copy link
Member

👍

@FxKu FxKu merged commit 625e804 into zalando:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FxKu FxKu FxKu left review comments

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@jopadi jopadi Awaiting requested review from jopadi jopadi is a code owner

@idanovinda idanovinda Awaiting requested review from idanovinda idanovinda is a code owner

@hughcapet hughcapet Awaiting requested review from hughcapet hughcapet is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.9

Development

Successfully merging this pull request may close these issues.

Add operator deployment readiness probes

3 participants

@dmvolod @FxKu @idanovinda