Skip to content

Commit 3dd503f

Browse files
haruhisa-shinfujii
authored andcommitted
[Win] WebInspector: Support remote connection by hostname
https://bugs.webkit.org/show_bug.cgi?id=253136 Reviewed by Fujii Hironori. It would be nice if RemoteInspector could connect by hostname as well as IP address. * Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp: (Inspector::Socket::connect): Canonical link: https://commits.webkit.org/261109@main
1 parent 53cde67 commit 3dd503f

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

Source/JavaScriptCore/inspector/remote/socket/win/RemoteInspectorSocketWin.cpp

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,17 @@ std::optional<PlatformSocketType> connect(const char* serverAddress, uint16_t se
162162
struct sockaddr_in address = { };
163163

164164
address.sin_family = AF_INET;
165-
::inet_pton(AF_INET, serverAddress, &address.sin_addr);
165+
int ret = ::inet_pton(AF_INET, serverAddress, &address.sin_addr);
166+
if (ret != 1) {
167+
struct addrinfo hints = { };
168+
struct addrinfo* res;
169+
hints.ai_socktype = SOCK_STREAM;
170+
hints.ai_family = AF_INET;
171+
if (!getaddrinfo(serverAddress, 0, &hints, &res)) {
172+
address.sin_addr = ((struct sockaddr_in*)(res->ai_addr))->sin_addr;
173+
freeaddrinfo(res);
174+
}
175+
}
166176
address.sin_port = htons(serverPort);
167177

168178
auto socket = connectTo(address);

0 commit comments

Comments
 (0)