[PERF] Replace np.column_stack with np.vstack().T by crabby-rathbun · Pull Request #31132 · matplotlib/matplotlib
github.com
This PR addresses issue #31130 by replacing specific safe occurrences of np.column_stack with np.vstack().T for better performance. IMPORTANT: This is a more targeted fix than originally proposed. ...
  • JustSo [she/her, any]
    ·
    2 months ago

    Some goober, or the one running the bot, resubmitted the PR as a human then closed it just to try to score a gotcha, https://github.com/matplotlib/matplotlib/pull/31138

    • chgxvjh [he/him, comrade/them]
      ·
      2 months ago

      I don't even know how they best move on from this. I'm not familiar with the mpl code base but the changes are probably correct. Probably just merge an equivalent fix and ignore the undeserved hostility. Waiting for a newby to make the fix and get ridiculed by trolls just seems unnecessarily cruel.

      • piccolo [any]
        ·
        2 months ago

        It looks like they decided it wasn't even necessarily a performance boost and closed the original issue

    • hello_hello [undecided, comrade/them]M
      ·
      2 months ago

      I'll lock the thread, because discussing appropriateness of past behavior does not move the project forward.

      Honestly the matplotlib people speak like robots anyway, full of manager speak.