Member-only story
Tips for Reviewing Pull Requests
Reviewing pull requests is a vital part of the software development process. Granted, perfect pull requests do not need reviews. But we are imperfect creatures operating in a changing world.
I prepared this list for myself when I became a senior developer. A senior developer’s job isn’t just to produce code at volume; they should review pull requests with the extra scrutiny their experience affords them.
Read the description.
It can be tempting to jump right into the files. I often look at the diff and go for it if it is reasonable, but I am improving. I have posted questions whose answers were prominently featured in the description many times. Someone put forth the effort to organize their thoughts and explain their changes in a way they think will help you. Not reading it is outright rude.
If there is a ticket linked, read the ticket.
Tickets are not to be taken at face value, but key considerations and decisions are ideally documented on tickets. Understanding the ask helps you start your review from a zoomed-out perspective.
