<?xml version="1.0" encoding="UTF-8"?><rss xmlns:dc="http://purl.org/dc/elements/1.1/" xmlns:content="http://purl.org/rss/1.0/modules/content/" xmlns:atom="http://www.w3.org/2005/Atom" version="2.0" xmlns:cc="http://cyber.law.harvard.edu/rss/creativeCommonsRssModule.html">
    <channel>
        <title><![CDATA[Stories by Magdalena Nelson on Medium]]></title>
        <description><![CDATA[Stories by Magdalena Nelson on Medium]]></description>
        <link>https://medium.com/@magdalenaalgawam?source=rss-5b68d599a6e------2</link>
        <image>
            <url>https://cdn-images-1.medium.com/fit/c/150/150/1*-3xsJMizsy2-xv6CTu_qiw.jpeg</url>
            <title>Stories by Magdalena Nelson on Medium</title>
            <link>https://medium.com/@magdalenaalgawam?source=rss-5b68d599a6e------2</link>
        </image>
        <generator>Medium</generator>
        <lastBuildDate>Sat, 21 Nov 2026 07:24:09 GMT</lastBuildDate>
        <atom:link href="https://medium.com/@magdalenaalgawam/feed" rel="self" type="application/rss+xml"/>
        <webMaster><![CDATA[yourfriends@medium.com]]></webMaster>
        <atom:link href="http://medium.superfeedr.com/" rel="hub"/>
        <item>
            <title><![CDATA[How not to give feedback like a d*ck — the inevitable tales of code reviews.]]></title>
            <link>https://medium.com/@magdalenaalgawam/how-not-to-give-feedback-like-a-d-ck-the-inevitable-tales-of-code-reviews-fc98ca7582b3?source=rss-5b68d599a6e------2</link>
            <guid isPermaLink="false">https://medium.com/p/fc98ca7582b3</guid>
            <category><![CDATA[codelikeagirl]]></category>
            <category><![CDATA[code]]></category>
            <category><![CDATA[code-review]]></category>
            <category><![CDATA[software-development]]></category>
            <dc:creator><![CDATA[Magdalena Nelson]]></dc:creator>
            <pubDate>Fri, 12 Oct 2018 16:52:54 GMT</pubDate>
            <atom:updated>2018-10-12T18:19:19.798Z</atom:updated>
            <content:encoded><![CDATA[<h4>How not to give feedback like a d*ck — the inevitable tales of code reviews.</h4><p>“If we have data, let’s look at data. If all we have are opinions, let’s go with mine.” <br><strong>Jim Barksdale</strong></p><p>We’ve all been there. Coming across a hard problem, and by hard I do not mean NP-hard. I mean challenging engineering task at hand with limited resources (time, space and everything else: computational complexity), with the middleware written 15 years ago in a language no one uses anymore, by people who left the company, with a tight deadline and little resources. After spending time coming up with the solution, looking for the most efficient algorithm, making sure it scales with the size of the input parameters. Failing. Trying again. Optimizing. Failing again. Looking at the<strong> big O</strong> (just google the big O notation if you are unfamiliar) and <strong>big Oh</strong>’s. Coming up with the solution that is O(logn) after the team has agreed we can’t get beyond O(n). Feeling almost like a superhero, ready to announce with our input size, the program will require only 3h to run, not 300h as initially thought.</p><p>Finally we give our well crafted solution to a peer for a review, only to find out: “This is wrong. You should not do it this way. That is not how it is supposed to be written. It could be more efficient.” You could say hearing a feedback like that from someone formally more senior in the team should humble me, and make me feel sorry for the ridiculously incorrect piece of software I wrote… Maybe it’s my curiosity, maybe the luck of having amazing mentors and peers in Germany early in my career, but when I hear negative words like wrong or incorrect, I require evidence. I tested it. Solution IS correct. It IS scalable. So I am sorry dear colleague, you would have to come up with convincing proof for me to believe differently. It is not that I don’t believe I can be wrong. I am. Many times. You see, I am a human, we err.. I came to terms with it. But I did test this particular solution and it is correct and I have a proof at hand.. so, dear peer, let’s call him John, so John just tell me: “what is wrong with my solution..?” “Oh Magda you millennials, you don’t know how to take feedback”; “you are full of yourself”; “you don’t belong in the big boys club” — the list of ridiculously inappropriate comments goes on.</p><figure><img alt="" src="https://cdn-images-1.medium.com/max/420/1*FLNEdBkhs0diE86SCAL3Tw.png" /></figure><p>Before I continue with the tale of John, let me tell you how I see feedback. I believe there are 3 different things that are spotted during a code review:</p><ol><li><strong>Bug</strong></li><li><strong>Computationally correct, but not efficient or not scalable solution</strong></li><li><strong>Computationally correct, efficient, scalable, but not reviewing peer’s favourite design pattern (although fully justifiable in this particular case)</strong></li></ol><p><strong>1.Bug </strong><br>If I made a bug, no matter how you communicate it — I made a mistake, I need to ask myself why I did it and try to make sure it doesn’t happen again. As a decent human being, you can just state the fact. Help me understand why it happened, let me learn from it and move on with my life. But not if you are John. John will call it a ‘monstrous mistake’ or a ‘critical bug’. John will make sure the team knows what a lousy programmer you are. John will tell everyone that we might not be meeting the deadline, because of your monstrous mistake (even if it’s just a typo in your last minute changes, because the company is understaffed and they just threw one more task at you that you really do not have any capacity to take). John will make sure you feel like a failure at least for 2 minutes. He wants you to understand what a joke of a human being you are….not to mention s**t programmer.</p><p><strong>2. Computationally correct, but not efficient or not scalable solution.</strong><br> I would like to say I am a genius programmer and everything I do is correct, best and shiny. But it is not. Faced with a tough deadline, for a one-off I do not always optimize. Sometimes the trade-offs of optimizing are not worth it if I know something in the most brute version will take a day to run and 2h to develop. I might just agree for that day to run if I have resources at hand, because I know optimizing it would take a couple of days of development and I only need to run it once. These are best judgment calls at times. Sometimes, I might also not come up with the best solution. There might be something I missed. It must be one of those days and I could have spotted better solution. But worry not, here comes John for the rescue. If you explain to him why you didn’t optimize, and how the cost for this particular one-off was in your opinion too high, he will tell you good programmers never cut corners and it just shows, as an engineer, you suck. You do. Don’t argue. You won’t win. It can end up in endless talk and you just will not win. It’s one of those ‘don’t argue with an idiot, he will drag you to his level, and beat you with experience’. I just let it go. Then there is the second part … you simply didn’t see a more optimal solution. You are a human, that is why we have pair programming, so we can come to the best collective solution, though obviously not if you work with John. John will try to make you feel like a piece of s**t, so what I learned is just to say: “Yes John you are right; there is a better solution I could come up with. Thank you for spotting it, I will implement it and please let me know what you think.” As much as I find him difficult, John was right, I was wrong, and crucially, I made John’s day. He speaks about me missing the best possible solution in the office, he tries to show people macro-holes in my micro-knowladge, he feels like the Wizard of Oz, like Padre in the Godfather and Padre showed me mercy and taught me how to be a good engineer. Thank you Padre. Your grace and mercy will never be forgotten.</p><p><strong>3. Computationally correct, efficient, scalable, but not reviewing peer’s favourite design pattern (although fully justifiable in this particular case)<br></strong> I came up with a solution. I chose a specific pattern or order of things that is correct and I am a happy with the hard work I have managed to complete. I even had another peer review it and give me the green light for deployment…only, John knew you were given challenging stuff, so don’t deploy just yet… Here comes John. John will argue that there is a better solution, so you ask him to prove it — a fair request in the circumstances. He’s already offended by you daring to challenge his status and seniority, but given how stubborn you are in asking for computational complexity, after comparing both solutions he realizes what you already know (you did consider his solution, but made an educated decision that the one you chose is more suitable for the current problem) both solutions have the same computational complexity. They are equally good. But he won’t take it. He wants you to rewrite the code and at this point, the millennial in me says no. John always starts with the t-shirt when he gets dressed for work. I start with the trousers. I believe it’s a matter of personal taste and opinion, because both approaches have nothing to do with better or worse, but what one prefers to do. If it’s a matter of preference I won’t let you have it John. The argument continues, peers get involved, they prefer not to, but John tries to prove his point. Left disappointed with no support from colleagues, John reluctantly and with ill grace lets me deploy my version. There is an air of the storm that has just passed and the silence in the office. Everybody feels awkward. There is another John, who wishes he had popcorn, but there are other guys, who go through code review with John and they wish they had the b***s to argue as I did, and they are happy someone finally stands up to John. Funny how one John managed to make the whole team uncomfortable.</p><p>So … how not to give feedback like a d*ck?<br> TLDR; DON’T BE JOHN.</p><p>Feedback can be constructive actionable feedback that makes me grow as a human and an engineer or negative criticism that makes me unreceptive and defensive. Make your choice Johns! Now from my early career enter Martin, from whom I was always open to feedback and who pushed me to develop my skills as a software engineer. He always helped me spot my gaps. I did not react to his feedback. I responded to it.</p><p>I’ve tried to understand why feedback from John provoked a negative response. Even in situations when I suspected he might be right my response invariable would also be negative. Yes I hold my hands up. But the latter scenario brought the realization that communication is the key. Yes indeed, the old reliable is still worth it’s place in the 21st — ‘it’s not what we say — it’s how we say it’. Whenever I hear: “Oh Magda, you millennials, you don’t know how to take feedback”; “you are full of yourselves”; “you don’t belong in the big boys club” — to all you Johns out there — you’re not helping.</p><p>It should be obvious to John that negative, condescending and patronizing comments/direction are counter-productive. I understand you are older John, but it doesn’t mean you always have the better solution. Martin would always try to help see things differently, or help come to the most efficient solution, which as a fresh grad really helped to think in a certain way. He would never say you should do it his way or a different way; he would always ask: “do you think there might be a better solution?”. Whenever there was a challenging piece of software to write we always did pair programming, because as engineers, we often collectively come up with a better solution. That’s just how Martin’s team worked. With John, on the other hand, you sit in your corner, work your butt off and then told your solution isn’t. I’ve seen such a work atmosphere generate indifference in a team, which is not the ideal in this type of pressured environment, to put it mildly. So — John, if you know better, then let me suggest a kick-off meeting, discuss the architecture to come up with the optimally best solution and we might, just might reduce the negativity, increase our output and smiles all round!</p><p>So — when giving feedback, it’s actually not hard not to be a John.</p><img src="https://medium.com/_/stat?event=post.clientViewed&referrerSource=full_rss&postId=fc98ca7582b3" width="1" height="1" alt="">]]></content:encoded>
        </item>
    </channel>
</rss>