File highlight+data range #1813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 15, 2019 20:37
* Removed package-lock * Improved File highlight
RunDevelopment
approved these changes
Mar 16, 2019
Member
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
@atomize Thank you for merging my changes so quickly!
There's only one thing I'd like to discuss (see comment) then this is ready to merge IMO.
Because I'm not comfortable with reviewing code I partly wrote myself, another maintainer will have the final word on this.
/cc @mAAdhaTTah
Member
|
I resolved the merge conflicts and touched it up a little. I'm sorry for the long delay @atomize! |
RunDevelopment
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends built-in file-highlight plugin with data-range capability. ( #1810 & #1812 )