Elm: Recognise unicode escapes as valid Char #3105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunDevelopment
requested changes
Oct 3, 2021
Member
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
Thanks for the PR @hoonweiting!
Only one nit!
Co-authored-by: Michael Schmidt <[email protected]>
RunDevelopment
approved these changes
Oct 3, 2021
Member
|
Thank you for contributing @hoonweiting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Elm recognises unicode escapes from
'\u{0000}'to'\u{10FFFF}'as valid Char. Not sure if the regex I modified is the best way to do it though!