escape values passed to --unset - #2530
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Windows-specific cleanup failure in actions/checkout by ensuring the value passed to git config --unset is treated as a literal pattern (rather than an unescaped regex), preventing invalid pattern errors and stale includeIf entries during post-job cleanup.
Changes:
- Escape
configValuewhen invokinggit config --unsetto avoid regex parsing errors for Windows-style paths. - Update the compiled
dist/index.jsbundle to reflect the source change.
Show a summary per file
| File | Description |
|---|---|
src/git-command-manager.ts |
Escapes the --unset value pattern to prevent regex errors (notably on Windows backslash paths). |
dist/index.js |
Regenerated bundle reflecting the escaped --unset value pattern. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/2 changed files
- Comments generated: 1
- Review effort level: Low
AllanGuigou
approved these changes
Jul 17, 2026
Merged
1 task
1 task
1 task
1 task
This was referenced Jul 27, 2026
1 task
20 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2528 by escaping the value passed to
git config --unset. This prevents Windows credential config paths from failing to match or producing invalid-pattern errors, leaving stale includeIf entries behind.