Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 13.0.3
Choose a base ref
...
head repository: angular/angular-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 13.0.4
Choose a head ref
  • 10 commits
  • 21 files changed
  • 5 contributors

Commits on Nov 18, 2021

  1. fix(@schematics/angular): address eslint linting failures in test.ts

    Closes #22171
    
    (cherry picked from commit 37a7239)
    alan-agius4 committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    372e2e6 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. docs: remove e2e folder reference from new spec

    (cherry picked from commit a57dafb)
    billyjov authored and alan-agius4 committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    6650765 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. fix(@angular/cli): logic which determines which temp version of the C…

    …LI is to be download during `ng update`
    
    Previously, when using an older version of the Angular CLI, during `ng update`, we download the temporary `latest` version to run the update. The ensured that when running that the runner used to run the update contains the latest bug fixes and improvements.
    
    This however, can be problematic in some cases. Such as when there are API breaking changes, when running a relatively old schematic with the latest CLI can cause runtime issues, especially since those schematics were never meant to be executed on a CLI X major versions in the future.
    
    With this change, we improve the logic to determine which version of the Angular CLI should be used to run the update.
    
    Below is a summarization of this.
    
    - When using the `--next` command line argument, the `@next` version of the CLI will be used to run the update.
    - When updating an `@angular/` or `@nguniversal/` package, the target version will be used to run the update. Example: `ng update @angular/core@12`,  the update will run on most recent patch version of `@angular/cli` of that major version `@12.2.6`.
    - When updating an `@angular/` or `@nguniversal/` and no target version is specified. Example: `ng update @angular/core` the update will run on most latest version of the `@angular/cli`.
    - When updating a third-party package, the most recent patch version of the installed `@angular/cli` will be used to run the update. Example if `13.0.0` is installed and `13.1.1` is available on NPM, the latter will be used.
    
    (cherry picked from commit 1e9e890)
    alan-agius4 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    250a58b View commit details
    Browse the repository at this point in the history
  2. fix(@angular-devkit/build-angular): transform remapped sourcemap into…

    … a plain object
    
    `remapping` returns a SourceMap object and not a plain object. This causes
    Babel to fail with `don't know how to turn this value into a node` when
    invoked from `istanbul-lib-instrument` as Babel checks if the value is a
    plain object.
    
    See: https://github.com/babel/babel/blob/780aa48d2a34dc55f556843074b6aed45e7eabeb/packages/babel-types/src/converters/valueToNode.ts#L115-L130
    
    This was previously fixed in commit da1733c
    but the fix was lost as part of commit 0c44ab3.
    
    (cherry picked from commit 5805c78)
    divdavem authored and alan-agius4 committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    4d01d4f View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. fix(@angular/cli): exit with a non-zero error code when migration fai…

    …ls during `ng update`
    
    In some cases, when a migration fails an error is not thrown, instead the `executeMigration` return a `false` value when resolved.
    
    With this change, we fix an issue were failed migrations resulted in the process of not terminating with a non-zero error code.
    
    (cherry picked from commit b9cd68f)
    alan-agius4 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    ded7b5c View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. fix(@ngtools/webpack): JIT mode CommonJS accessing inexistent `defaul…

    …t` property
    
    With this change we fix an issue in JIT mode were we try to access an inexistent `default` property of styles modules when emitted in CJS.
    
    Also, we now emit templates modules without the default property when not targeting ES2015 or greater to normalize the how to `require` templates and styles.
    
    Closes #21588
    
    (cherry picked from commit b3f71c5)
    alan-agius4 authored and dgp1130 committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    4d918ef View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. fix(@angular-devkit/build-angular): don't watch nested node_modules

    … when polling is enabled
    
    Previously the glob didn't catch nested `node_modules`.
    
    Closes #22163
    alan-agius4 authored and dgp1130 committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    647a5f0 View commit details
    Browse the repository at this point in the history
  2. build: add pkg_npm rules for remaining packages

    (cherry picked from commit 83b7390)
    kormide authored and dgp1130 committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    0a8c13d View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. fix(@angular-devkit/build-angular): correctly extract messages when u…

    …sing cached build (#22266)
    
    * fix(@angular-devkit/build-angular): correctly extract messages when using cached build
    
    Extracted messages are not part of Webpack pipeline and hence they cannot be retrieved from cache. Therefore, we need to mark the extraction loader as non cacheable.
    
    Closes #22264
    
    * fixup! fix(@angular-devkit/build-angular): correctly extract messages when using cached build
    
    (cherry picked from commit 52c6c3d)
    alan-agius4 authored and dgp1130 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    b835389 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1441af7 View commit details
    Browse the repository at this point in the history
Loading