Skip to content

feat: Add impersonated signer #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 29, 2023
Merged

feat: Add impersonated signer #1694

merged 7 commits into from
Nov 29, 2023

Conversation

salrashid123
Copy link
Contributor

Adds ability to signblob and issue gcs signedurl using impersonated credentials

Fixes #1443 🦕

added test cases to check generic client.sign()

  googleauth
    googleauth
      for impersonated types
        for impersonated credentials signing
          ✔ should use IAMCredentials signBlob endpoint when impersonation is used


  impersonated
    ✔ should sign a blob

coverage skips signer call when used with GCS clients (eg, googleauth.ts 1031-1032)

impersonated.ts | 100 | 63.63 | 100 | 100 | 122-125,127,188-195 googleauth.ts | 95.23 | 87.09 | 100 | 95.23 | 221,245-246,316,321-324,452-457,548-551,553-556,558-561,563-566,576-583,591-594,780-781,884,914-915,927-928,1031-1032 `

@salrashid123 salrashid123 requested review from a team as code owners November 24, 2023 13:18
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 24, 2023
@salrashid123 salrashid123 changed the title Add impersonated signer feat: Add impersonated signer Nov 24, 2023
danielbankhead
danielbankhead approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@danielbankhead danielbankhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; a few minor nits

@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 29, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 29, 2023
@danielbankhead danielbankhead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 29, 2023
@danielbankhead danielbankhead merged commit cb78a1b into googleapis:main Nov 29, 2023
@release-please release-please bot mentioned this pull request Nov 29, 2023
Merged
@salrashid123 salrashid123 deleted the add-impersonated-signer branch November 29, 2023 20:50
@cojenco cojenco mentioned this pull request Dec 4, 2023
Closed
@howlettga howlettga mentioned this pull request Oct 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danielbankhead danielbankhead danielbankhead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Impersonated credentials should implement sign() capability

4 participants

@salrashid123 @danielbankhead @yoshi-kokoro @d-goog