Skip to content

feat: Update gcp metadata dependency #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

feat: Update gcp metadata dependency #1703

merged 1 commit into from
Nov 30, 2023

Conversation

JrSchild
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1702 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 30, 2023
@JrSchild JrSchild marked this pull request as ready for review November 30, 2023 11:20
@JrSchild JrSchild requested review from a team as code owners November 30, 2023 11:20
@danielbankhead danielbankhead added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 30, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 30, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 30, 2023
@danielbankhead danielbankhead merged commit 615bdd9 into googleapis:main Nov 30, 2023
@release-please release-please bot mentioned this pull request Nov 30, 2023
Merged
@JrSchild JrSchild deleted the feat/update-gcp-metadata branch November 30, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danielbankhead danielbankhead danielbankhead approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

TypeError: gpcMetadata.universe is not a function with 9.3.0 after upgrade from 9.2.0 (with google-gax) on cloud run

3 participants

@JrSchild @danielbankhead @yoshi-kokoro