Skip to content

Conversation

@mrstork
Copy link
Contributor

@mrstork mrstork commented Jun 3, 2025

Summary


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork force-pushed the e2e-test-for-npx-awareness branch from eebc41b to fe9a616 Compare June 3, 2025 19:00
@github-actions
Copy link

github-actions bot commented Jun 3, 2025

📊 Benchmark results

Comparing with 03fd72d

  • Dependency count: 1,148 (no change)
  • Package size: 271 MB (no change)
  • Number of ts-expect-error directives: 397 (no change)

@mrstork mrstork changed the title E2e test for npx awareness fix: pnpx context awareness + e2e tests Jun 3, 2025
@mrstork mrstork marked this pull request as ready for review June 4, 2025 21:00
@mrstork mrstork requested a review from a team as a code owner June 4, 2025 21:00
Copy link
Member

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

})
})

const runTests: [packageManager: string, config: RunTest][] = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice approach you came up with! Just partitioning into two sets of table tests makes sense.

@mrstork mrstork enabled auto-merge (squash) June 4, 2025 22:19
@mrstork mrstork merged commit 8bb3fd2 into main Jun 4, 2025
52 checks passed
@mrstork mrstork deleted the e2e-test-for-npx-awareness branch June 4, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants