Parse based on CharSequence internally

Only access to CharSequence is via DateTimeParserBucket
Fixes JodaOrg#111

Author: jodastephen

RELEASE-NOTES.txt

@@ -30,6 +30,13 @@ Enhancements since 2.3
   Potential for performance improvements due to lower garbage churn
   Improvement only of interest to applications willing to write specialist code
 
+- Support CharSequence throughout parsing
+  Ensure that CharSequence can be used in parsing [#111]
+  This can only be accessed by creating a mutable DateTimeParserBucket
+  The bucket is a low-level construct for advanced use cases
+  Potential for performance improvements due to lower garbage churn
+  No API change
+
 - Support Appendable throughout printing
   Ensure that Appendable can be used efficiently in printing [#120, #121, #122]
   No API change

src/main/java/org/joda/time/format/DateTimeFormat.java

@@ -785,7 +785,7 @@ private static int selectStyle(char ch) {
 
     //-----------------------------------------------------------------------
     static class StyleFormatter
-            implements InternalPrinter, DateTimeParser {
+            implements InternalPrinter, InternalParser {
 
         private static final ConcurrentHashMap<StyleFormatterCacheKey, DateTimeFormatter> cCache = new ConcurrentHashMap<StyleFormatterCacheKey, DateTimeFormatter>();
 
@@ -820,8 +820,8 @@ public int estimateParsedLength() {
             return 40;  // guess
         }
 
-        public int parseInto(DateTimeParserBucket bucket, String text, int position) {
-            DateTimeParser p = getFormatter(bucket.getLocale()).getParser();
+        public int parseInto(DateTimeParserBucket bucket, CharSequence text, int position) {
+            InternalParser p = getFormatter(bucket.getLocale()).getParser0();
             return p.parseInto(bucket, text, position);
         }
 

src/main/java/org/joda/time/format/DateTimeFormatter.java

@@ -92,7 +92,7 @@ public class DateTimeFormatter {
     /** The internal printer used to output the datetime. */
     private final InternalPrinter iPrinter;
     /** The internal parser used to output the datetime. */
-    private final DateTimeParser iParser;
+    private final InternalParser iParser;
     /** The locale to use for printing and parsing. */
     private final Locale iLocale;
     /** Whether the offset is parsed. */
@@ -115,7 +115,7 @@ public class DateTimeFormatter {
      */
     public DateTimeFormatter(
             DateTimePrinter printer, DateTimeParser parser) {
-        this(DateTimePrinterInternalPrinter.of(printer), parser);
+        this(DateTimePrinterInternalPrinter.of(printer), DateTimeParserInternalParser.of(parser));
     }
 
     /**
@@ -126,7 +126,7 @@ public DateTimeFormatter(
      * @param parser  the internal parser, null if cannot parse
      */
     DateTimeFormatter(
-            InternalPrinter printer, DateTimeParser parser) {
+            InternalPrinter printer, InternalParser parser) {
         super();
         iPrinter = printer;
         iParser = parser;
@@ -142,7 +142,7 @@ public DateTimeFormatter(
      * Constructor.
      */
     private DateTimeFormatter(
-            InternalPrinter printer, DateTimeParser parser,
+            InternalPrinter printer, InternalParser parser,
             Locale locale, boolean offsetParsed,
             Chronology chrono, DateTimeZone zone,
             Integer pivotYear, int defaultYear) {
@@ -200,6 +200,10 @@ public boolean isParser() {
      * @return the internal parser; is null if parsing not supported
      */
     public DateTimeParser getParser() {
+        return InternalParserDateTimeParser.of(iParser);
+    }
+
+    InternalParser getParser0() {
         return iParser;
     }
 
@@ -728,7 +732,7 @@ private InternalPrinter requirePrinter() {
      * @throws IllegalArgumentException if any field is out of range
      */
     public int parseInto(ReadWritableInstant instant, String text, int position) {
-        DateTimeParser parser = requireParser();
+        InternalParser parser = requireParser();
         if (instant == null) {
             throw new IllegalArgumentException("Instant must not be null");
         }
@@ -770,7 +774,7 @@ public int parseInto(ReadWritableInstant instant, String text, int position) {
      * @throws IllegalArgumentException if the text to parse is invalid
      */
     public long parseMillis(String text) {
-        DateTimeParser parser = requireParser();
+        InternalParser parser = requireParser();
         Chronology chrono = selectChronology(iChrono);
         DateTimeParserBucket bucket = new DateTimeParserBucket(0, chrono, iLocale, iPivotYear, iDefaultYear);
         return bucket.doParseMillis(parser, text);
@@ -827,7 +831,7 @@ public LocalTime parseLocalTime(String text) {
      * @since 2.0
      */
     public LocalDateTime parseLocalDateTime(String text) {
-        DateTimeParser parser = requireParser();
+        InternalParser parser = requireParser();
 
         Chronology chrono = selectChronology(null).withUTC();  // always use UTC, avoiding DST gaps
         DateTimeParserBucket bucket = new DateTimeParserBucket(0, chrono, iLocale, iPivotYear, iDefaultYear);
@@ -868,7 +872,7 @@ public LocalDateTime parseLocalDateTime(String text) {
      * @throws IllegalArgumentException if the text to parse is invalid
      */
     public DateTime parseDateTime(String text) {
-        DateTimeParser parser = requireParser();
+        InternalParser parser = requireParser();
 
         Chronology chrono = selectChronology(null);
         DateTimeParserBucket bucket = new DateTimeParserBucket(0, chrono, iLocale, iPivotYear, iDefaultYear);
@@ -913,7 +917,7 @@ public DateTime parseDateTime(String text) {
      * @throws IllegalArgumentException if the text to parse is invalid
      */
     public MutableDateTime parseMutableDateTime(String text) {
-        DateTimeParser parser = requireParser();
+        InternalParser parser = requireParser();
 
         Chronology chrono = selectChronology(null);
         DateTimeParserBucket bucket = new DateTimeParserBucket(0, chrono, iLocale, iPivotYear, iDefaultYear);
@@ -945,8 +949,8 @@ public MutableDateTime parseMutableDateTime(String text) {
      * 
      * @throws UnsupportedOperationException if parsing is not supported
      */
-    private DateTimeParser requireParser() {
-        DateTimeParser parser = iParser;
+    private InternalParser requireParser() {
+        InternalParser parser = iParser;
         if (parser == null) {
             throw new UnsupportedOperationException("Parsing not supported");
         }