Skip to content

perf(es/minifier): Adjust parallelism threshold #10260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

perf(es/minifier): Adjust parallelism threshold #10260

merged 2 commits into from
Mar 24, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 24, 2025

Description:

I'll post the benchmark result soon.


es/minifier/real/es/minifier/real/sequential
                        time:   [10.736 s 10.755 s 10.776 s]
                        change: [+0.8409% +1.4726% +1.9502%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 1 outliers among 10 measurements (10.00%)
  1 (10.00%) high mild
Benchmarking es/minifier/real/es/minifier/real/parallel: Warming up for 3.0000 s
Warning: Unable to complete 10 samples in 5.0s. You may wish to increase target time to 27.6s.
es/minifier/real/es/minifier/real/parallel
                        time:   [2.3177 s 2.3962 s 2.4913 s]
                        change: [-18.366% -10.442% -1.8769%] (p = 0.04 < 0.05)
                        Performance has improved.
Found 4 outliers among 10 measurements (40.00%)
  2 (20.00%) low mild
  1 (10.00%) high mild
  1 (10.00%) high severe

I'll try more adjustments over time

@kdy1 kdy1 added this to the Planned milestone Mar 24, 2025
@kdy1 kdy1 self-assigned this Mar 24, 2025
Copy link

changeset-bot bot commented Mar 24, 2025

🦋 Changeset detected

Latest commit: b0bdd19

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codspeed-hq bot commented Mar 24, 2025

CodSpeed Performance Report

Merging #10260 will not alter performance

Comparing kdy1/more-par-if (b0bdd19) with main (9c9b0ba)

Summary

✅ 152 untouched benchmarks

@kdy1 kdy1 marked this pull request as ready for review March 24, 2025 04:12
@kdy1 kdy1 requested a review from a team as a code owner March 24, 2025 04:12
kodiakhq[bot]
kodiakhq bot previously approved these changes Mar 24, 2025
@kdy1 kdy1 requested a review from a team as a code owner March 24, 2025 04:12
@kdy1 kdy1 merged commit 28cc6f6 into main Mar 24, 2025
169 checks passed
@kdy1 kdy1 deleted the kdy1/more-par-if branch March 24, 2025 04:43
@kdy1 kdy1 modified the milestones: Planned, v1.11.14 Mar 31, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant