Skip to content

fix(runner): comments between fixture destructures #8127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2025
Merged

fix(runner): comments between fixture destructures #8127

merged 1 commit into from
Jun 9, 2025

Conversation

AriPerkkio
Copy link
Member

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

AriPerkkio
AriPerkkio commented Jun 9, 2025
View reviewed changes
pnpm-workspace.yaml
@@ -37,6 +37,7 @@ catalog:
pathe: ^2.0.3
sirv: ^3.0.1
std-env: ^3.9.0
strip-literal: ^3.0.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? I haven't set up pnpm catalogs before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess

@netlify Netlify
Copy link

netlify bot commented Jun 9, 2025

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7d81b14
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/684690f382a97e0008f49514
😎 Deploy Preview https://deploy-preview-8127--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AriPerkkio AriPerkkio marked this pull request as draft June 9, 2025 07:48
@AriPerkkio AriPerkkio force-pushed the fix/fixture-comments branch from 7d81b14 to 3972a4b Compare June 9, 2025 08:00
@AriPerkkio AriPerkkio marked this pull request as ready for review June 9, 2025 08:25
@sheremet-va sheremet-va merged commit dc469f2 into vitest-dev:main Jun 9, 2025
23 of 24 checks passed
@AriPerkkio AriPerkkio deleted the fix/fixture-comments branch June 9, 2025 11:09
@renovate renovate bot mentioned this pull request Jun 9, 2025
Open
1 task
This was referenced Jun 10, 2025
Closed
Merged
@renovate renovate bot mentioned this pull request Jul 2, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Comments between destructured fixture lines breaks values
2 participants
@AriPerkkio @sheremet-va