Menu ▾ ▴

#476 mh-display-with-external-viewer modifies buffer in Emacs 24.4

mh-e-8.7
open
Bill Wohler
None
5
2020-05-08
2014-08-05
Bill Wohler
No

View an HTML file, for example, with `K e' (`mh-display-with-external-viewer'). Note that the file modification marker gets set. When you move to the next message, you have to first answer the question, Message 88 modified; discard changes? (yes or no).

This is a regression from Emacs version 24.3.

Discussion

  • Mike Kupfer

    Mike Kupfer - 2014-09-22

    Actually, I see this with 24.3 on Solaris, e.g., when using "K e" to view a PDF with Evince (GNOME 2).

    The message buffer ends up with text like

    [2. application/pdf; Travel Reservation.pdf]...

    ** (evince:5290): WARNING **: Error setting file metadata: No such file or directory

    ** (evince:5290): WARNING **: Error setting file metadata: No such file or directory

    (evince:5290): GLib-GObject-WARNING **: gsignal.c:2593: instance '810e9d8' has no handler with id '913'

    (evince:5290): GLib-GObject-WARNING **: gsignal.c:2593: instance '810e9d8' has no handler with id '914'

     

  • Mike Kupfer

    Mike Kupfer - 2015-01-03

    John Covici also reports getting messages marked as modified when using lynx as the HTML renderer.

     

  • Mike Kupfer

    Mike Kupfer - 2015-06-21
    • Milestone: mh-e-8.6 --> mh-e-8.7
     

  • Mike Kupfer

    Mike Kupfer - 2015-12-24

    I just noticed this comment for mh-mm-display-part:

    ;; There is a bug in Gnus inline image display due to which an extra line
    ;; gets inserted every time it is viewed. To work around that problem we are
    ;; using an extra property 'mh-region to remember the region that is added
    ;; when the button is clicked. The region is then deleted to make sure that
    ;; no extra lines get inserted.

    Maybe something like that is needed for mh-display-with-external-viewer, too?

     

  • Jeffrey Honig

    Jeffrey Honig - 2015-12-26

    I am seeing this bug, so it is worth checking out.

     

  • Stephen Gildea

    Stephen Gildea - 2020-01-01

    Is this still a bug? I used to get "buffer modified",
    but I no longer do with Emacs 25 or the 27 release branch.

     

  • Mike Kupfer

    Mike Kupfer - 2020-01-01

    I still see it sometimes with Emacs 26.3, particularly when viewing PDF
    files with Evince. The problem seems to happen when the viewer writes
    something to stderr; the error message ends up in the show buffer.

     

    • minshall

      minshall - 2020-01-02

      i also still see it.

       

  • Stephen Gildea

    Stephen Gildea - 2020-05-08

    I can reproduce this in 27.0.91. It appears to be a timing issue with external viewers.

    MH-E points all MIME viewers at the show buffer. This works well for internal viewers: they update the show buffer, they finish, and MH-E sets the buffer as unmodified.

    This strategy doesn't work as well with external viewers. An external viewer is a background process, and it might write logging or error messages to the show buffer after MH-E has called (set-buffer-modified-p nil).

     

Log in to post a comment.