C++ JSON parser (Now in GitHub)

#24 Missing istream include in json_reader.cpp

Milestone: Unstable (example)

Status: closed-accepted

Owner: Aaron Jacobs

Labels: None

Priority: 5

Updated: 2015-03-06

Created: 2013-12-04

Creator: Quentin Fiard

Private: No

The json_reader.cpp is missing an include of <istream>, needed for
bool Reader::parse(std::istream& sin, ...). Failure to include it
leads to a missing definition of getline for istream.

This include was removed in revision 247 as part of a cleanup of
unnecessary includes of <iostream> to improve binary startup time,
but it should not have been removed in json_reader.cpp (or at least
should have been replaced by an include of <istream>).

Here is the patch:

Index: src/lib_json/json_reader.cpp

--- /src/lib_json/json_reader.cpp (revision 275)
+++ src/lib_json/json_reader.cpp (working copy)
@@ -13,6 +13,7 @@
#include <cstdio>
#include <cassert>
#include <cstring>
+#include <istream>
#include <stdexcept>

#if defined(_MSC_VER) && _MSC_VER >= 1400 // VC++ 8.0

Discussion

Quentin Fiard - 2013-12-04

Sorry I forgot about escaping the includes '<' '>'. Please find the patch attached.

missing_include.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Aaron Jacobs - 2014-01-29

Sorry for the delay, and thanks for the patch. Applied in r276.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Christopher Dunn - 2015-03-06

Description has changed:

Diff:

--- old +++ new @@ -1,4 +1,3 @@ - The json_reader.cpp is missing an include of <istream>, needed for bool Reader::parse(std::istream& sin, ...). Failure to include it

status: open --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Missing istream include in json_reader.cpp

C++ JSON parser (Now in GitHub)

Group

Searches

Help

#24 Missing istream include in json_reader.cpp

Index: src/lib_json/json_reader.cpp

Discussion