Download to read offline
Uploaded byFrank Sons
Effective Code Reviews (IPC 2018)
The document discusses the importance of effective peer code reviews as a key method to improve code quality. It emphasizes the need for a positive mindset, teamwork, and intentionality in the review process while providing tips for implementing effective practices like creating checklists and guidelines. It concludes with the assertion that successful code reviews depend on the experience and motivation of those involved.
More Related Content
Similar to Effective Code Reviews (IPC 2018)
Effective Code Reviews (IPC 2018)
- 1. Effective Code Reviews InternationalPHP Conference 2018, Berlin
- 2. Moin and hello FrankSonsFrank Sons FrankS FrankS http://code-quality.dehttp://code-quality.de
- 3. Wait, why areyou here? Anyone not doing code reviews?Anyone not doing code reviews? This is not about tools!This is not about tools!
- 4. The good news... „Peercode reviews are the single biggest thing you can do to improve your code.“ „Peer code reviews are the single biggest thing you can do to improve your code.“ Jeff Atwood – @codinghorror
- 5. A (very) smallAgenda The Status Quo of most code reviewsThe Status Quo of most code reviews Let’s make it more effectiveLet’s make it more effective
- 6. Status quo ofmost ReviewsStatus quo of most Reviews
- 8.
- 9. Developer Ego Who likesto be criticized?Who likes to be criticized? “That’s not my code!”“That’s not my code!”
- 10. Ofc, it’s yourchoice... „Everyone has the right and freedom to totally suck in private“ „Everyone has the right and freedom to totally suck in private“ Jeff Atwood – @codinghorror
- 11.
- 12. What is yourIntention? Why are you reviewing your code?Why are you reviewing your code? What are you looking for?What are you looking for?
- 13. Main Motivation forreviews?
- 14. Well, let’s lookat the real results
- 15.
- 16. Are you trackingyour Results? Fixing right now or later?Fixing right now or later? Different opinions?Different opinions? How successful are your reviews?How successful are your reviews?
- 17. So what dowe get? Results depend on experience, timing and motivation of the reviewing developer! Results depend on experience, timing and motivation of the reviewing developer!
- 19. Let’s make iteffectiveLet’s make it effective
- 20.
- 21. Leave your egoat the door „Attempt to be awesome in public and embrace the suck!“ „Attempt to be awesome in public and embrace the suck!“ Jeff Atwood – @codinghorror
- 22. Forget about “your”code Share the knowledgeShare the knowledge The Team is responsibleThe Team is responsible
- 23. Team reviews area good start
- 24.
- 25. The intention matters Whyare you reviewing your code?Why are you reviewing your code? What are you looking for?What are you looking for?
- 26.
- 27. Pick the rightmethod... Pull requests?Pull requests? Pair Programming?Pair Programming? Code Review meetings?Code Review meetings?
- 28. Create a codingguideline Don’t add stuff you can check with toolsDon’t add stuff you can check with tools Let the team create itLet the team create it It’s a living documentIt’s a living document
- 29.
- 30. Keep track ofresults Make sure you have follow upsMake sure you have follow ups Keep discussions separate from the reviewKeep discussions separate from the review Not everything needs to be fixed at onceNot everything needs to be fixed at once
- 31. Create a reviewchecklist Use your guidelines as a baseUse your guidelines as a base Checklists are great for reportsChecklists are great for reports
- 33. Make your reviewseffective! Leave your ego at the doorLeave your ego at the door Have a guidelineHave a guideline Follow up on your resultsFollow up on your results
- 34. No matter what... „Peercode reviews are the single biggest thing you can do to improve your code.“ „Peer code reviews are the single biggest thing you can do to improve your code.“ Jeff Atwood – @codinghorror
- 35.
- 36. Links ● http://blog.codeclimate.com/blog/2013/10/09/unexpected-outcomes-of-code-reviews/ ● http://blog.ptsecurity.com/2012/08/code-review-implemented-into-development.html ●https://blog.codinghorror.com/code-reviews-just-do-it/ ● https://www.slideshare.net/codinghorror/how-to-stop-sucking-and-be-awesome-instead ● https://martinfowler.com/bliki/CodeOwnership.html