Skip to content
This repository was archived by the owner on Feb 28, 2024. It is now read-only.

Update PCF8563T.cpp #87

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Update PCF8563T.cpp #87

merged 1 commit into from
Jun 7, 2022

Conversation

MrHyrex
Copy link
Contributor

@MrHyrex MrHyrex commented Jun 1, 2022 •
edited
Loading

fix bug in getDays() method.

Sometimes the getDays() function returns a value higher than 31. The value is typically 40 days too high and this happens whenever the getSeconds() returns a value higher than 40.

Eg. at 16:40:30 on the 1st of june getDays() returns 1, then 15 seconds later at 16:40:45 getDays() returns 41, and then 20 seconds later at 16:41:05 it returns 1 again.

Unlike the other get-functions in the PCF8563TClass the getDays() function does not filter out the 2 unused MSBs of the day register as it should according to the datasheet. This pr fixes that

@MrHyrex
Update PCF8563T.cpp
2d7d34f 
fix bug in getDays() method
manchoz
manchoz reviewed Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@manchoz manchoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

Memory usage change @ 2d7d34f

Board flash % RAM for global variables %
arduino:mbed_portenta:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/Analog_Out
flash		 % examples/Analog_Out
RAM for global variables		 % examples/Analog_input/Analog_input_0_10V
flash		 % examples/Analog_input/Analog_input_0_10V
RAM for global variables		 % examples/Analog_input/Analog_input_4_20mA
flash		 % examples/Analog_input/Analog_input_4_20mA
RAM for global variables		 % examples/Analog_input/Analog_input_NTC
flash		 % examples/Analog_input/Analog_input_NTC
RAM for global variables		 % examples/CAN/ReadCan
flash		 % examples/CAN/ReadCan
RAM for global variables		 % examples/CAN/WriteCan
flash		 % examples/CAN/WriteCan
RAM for global variables		 % examples/Digital_output
flash		 % examples/Digital_output
RAM for global variables		 % examples/Digital_programmable/CombinedIOExpander
flash		 % examples/Digital_programmable/CombinedIOExpander
RAM for global variables		 % examples/Digital_programmable/Digital_input
flash		 % examples/Digital_programmable/Digital_input
RAM for global variables		 % examples/Digital_programmable/GPIO_programmable
flash		 % examples/Digital_programmable/GPIO_programmable
RAM for global variables		 % examples/Encoders
flash		 % examples/Encoders
RAM for global variables		 % examples/Ethernet
flash		 % examples/Ethernet
RAM for global variables		 % examples/RS232
flash		 % examples/RS232
RAM for global variables		 % examples/RS485_fullduplex
flash		 % examples/RS485_fullduplex
RAM for global variables		 % examples/RS485_halfduplex
flash		 % examples/RS485_halfduplex
RAM for global variables		 % examples/RTC
flash		 % examples/RTC
RAM for global variables		 % examples/RTC_Alarm
flash		 % examples/RTC_Alarm
RAM for global variables		 % examples/Temp_probes_RTD
flash		 % examples/Temp_probes_RTD
RAM for global variables		 % examples/Temp_probes_Thermocouples
flash		 % examples/Temp_probes_Thermocouples
RAM for global variables		 % examples/USB_host
flash		 % examples/USB_host
RAM for global variables		 %
arduino:mbed_portenta:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,examples/Analog_Out<br>flash,%,examples/Analog_Out<br>RAM for global variables,%,examples/Analog_input/Analog_input_0_10V<br>flash,%,examples/Analog_input/Analog_input_0_10V<br>RAM for global variables,%,examples/Analog_input/Analog_input_4_20mA<br>flash,%,examples/Analog_input/Analog_input_4_20mA<br>RAM for global variables,%,examples/Analog_input/Analog_input_NTC<br>flash,%,examples/Analog_input/Analog_input_NTC<br>RAM for global variables,%,examples/CAN/ReadCan<br>flash,%,examples/CAN/ReadCan<br>RAM for global variables,%,examples/CAN/WriteCan<br>flash,%,examples/CAN/WriteCan<br>RAM for global variables,%,examples/Digital_output<br>flash,%,examples/Digital_output<br>RAM for global variables,%,examples/Digital_programmable/CombinedIOExpander<br>flash,%,examples/Digital_programmable/CombinedIOExpander<br>RAM for global variables,%,examples/Digital_programmable/Digital_input<br>flash,%,examples/Digital_programmable/Digital_input<br>RAM for global variables,%,examples/Digital_programmable/GPIO_programmable<br>flash,%,examples/Digital_programmable/GPIO_programmable<br>RAM for global variables,%,examples/Encoders<br>flash,%,examples/Encoders<br>RAM for global variables,%,examples/Ethernet<br>flash,%,examples/Ethernet<br>RAM for global variables,%,examples/RS232<br>flash,%,examples/RS232<br>RAM for global variables,%,examples/RS485_fullduplex<br>flash,%,examples/RS485_fullduplex<br>RAM for global variables,%,examples/RS485_halfduplex<br>flash,%,examples/RS485_halfduplex<br>RAM for global variables,%,examples/RTC<br>flash,%,examples/RTC<br>RAM for global variables,%,examples/RTC_Alarm<br>flash,%,examples/RTC_Alarm<br>RAM for global variables,%,examples/Temp_probes_RTD<br>flash,%,examples/Temp_probes_RTD<br>RAM for global variables,%,examples/Temp_probes_Thermocouples<br>flash,%,examples/Temp_probes_Thermocouples<br>RAM for global variables,%,examples/USB_host<br>flash,%,examples/USB_host<br>RAM for global variables,%
arduino:mbed_portenta:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 1, 2022
@aentinger aentinger merged commit 155bb20 into arduino-libraries:master Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manchoz manchoz manchoz left review comments

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MrHyrex @manchoz @aentinger @per1234