runtime: Add freestanding functions to get/set/delete UEFI variables #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-runtime-mod-vars
branch
from
698b597 to
5cbdb12
Compare
This will allow `make_boxed` to be used in `get_variable_boxed`.
nicholasbishop
force-pushed
the
bishop-runtime-mod-vars
branch
from
5cbdb12 to
800af86
Compare
The new version of `get_variable` returns the required size in the error data if the input buffer is too small. This allows `get_variable_boxed` to use `make_boxed`, and also makes `get_variable_size` unnecessary. Also added more info about errors to the docstrings. (Note: `variable_keys` function to come in a later commit.)
nicholasbishop
force-pushed
the
bishop-runtime-mod-vars
branch
from
800af86 to
3fe8b6b
Compare
phip1611
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of
get_variablereturns the required size in the error data if the input buffer is too small. This allowsget_variable_boxedto usemake_boxed, and also makesget_variable_sizeunnecessary.Also:
Alignfor[u8]to allowmake_boxedto work here.(Note:
variable_keysfunction to come in a later PR.)Checklist