making the proxy with NTLM work (for grizzly provider) #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
websocket is still not working.
|
basically this pull request is sum of two check-ins first one was working cut the second one is removing some not necessary code. |
|
For whatever reason, the pull request cannot be merged. Would you mind sending the complete diff to [email protected]? |
|
I have committed kerberos related changes too to my branch and this pull request does not contain it. |
|
would it help if i close this and make another pull request which contains both ntlm and kerberos related changes? |
|
Sure, let's give it a shot. |
|
closed this and opened created another request, this contains kerberos related changes as well. |
cs-workco
pushed a commit
to cs-workco/async-http-client
that referenced
this pull request
Apr 13, 2023
`redirectConfiguration` can't default to `false` as it's not a boolean value, and the default value is `RedirectConfiguration()`. Co-authored-by: Johannes Weiss <[email protected]> Co-authored-by: Artem Redkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling the proxy's NTLM auth, using NTLMEngine to generate required tokens.
detecting first, second level of handshakes and generating appropriate message types