-
Notifications
You must be signed in to change notification settings - Fork 443
chore(telemetry): integration error telemetry logs are sent through a function call #13510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 286 ± 4 ms. The average import time from base is: 286 ± 4 ms. The import time difference between this PR and base is: 0.3 ± 0.2 ms. The difference is not statistically significant (z = 1.43). Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-06-23 09:48:02 Comparing candidate commit 0ddaf04 in PR branch Found 0 performance improvements and 2 performance regressions! Performance is the same for 563 metrics, 7 unstable metrics. scenario:iastaspectsospath-ospathsplitdrive_aspect
scenario:iastaspectsospath-ospathsplitext_aspect
|
4c81fcd
to
74378d8
Compare
85ab73a
to
c459880
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing some type hints, otherwise lgtm
… function call (#13510) ## Motivation Integration related error telemetry logs were added in #11732. However, it is using a LogHandler. Therefore, to be able to report integration error logs to telemetry you needed to enable debug logs (as in the integration the errors are logged using debug level). However, telemetry activation should not be tied to the log level. The log handler will stay for the error part as it allows to reduce circular import (see the quoted PR above). ## What does this PR do ? - Add a call tied to the writer to report integration error logs to telemetry - Bump the level of the telemetry logs to error (so it appears in telemetry). - Modification to the redaction process: add `<REDACTED>` for every lines we are redacting (before we were only adding one `<REDACTED>` for the redaction of two lines) ## What this PR doesn't do - The PR does not effectively report any errors to telemetry. A discussion should take place in IDM to chose which errors are worth reporting to telemetry. ## Checklist - [X] PR author has checked that all the criteria below are met - The PR description includes an overview of the change - The PR description articulates the motivation for the change - The change includes tests OR the PR description describes a testing strategy - The PR description notes risks associated with the change, if any - Newly-added code is easy to change - The change follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) - The change includes or references documentation updates if necessary - Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) ## Reviewer Checklist - [x] Reviewer has checked that all the criteria below are met - Title is accurate - All changes are related to the pull request's stated goal - Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - Testing strategy adequately addresses listed risks - Newly-added code is easy to change - Release note makes sense to a user of the library - If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)
Motivation
Integration related error telemetry logs were added in #11732. However, it is using a LogHandler. Therefore, to be able to report integration error logs to telemetry you needed to enable debug logs (as in the integration the errors are logged using debug level). However, telemetry activation should not be tied to the log level.
The log handler will stay for the error part as it allows to reduce circular import (see the quoted PR above).
What does this PR do ?
<REDACTED>
for every lines we are redacting (before we were only adding one<REDACTED>
for the redaction of two lines)What this PR doesn't do
Checklist
Reviewer Checklist