-
Notifications
You must be signed in to change notification settings - Fork 443
feat(di): enable code origins for entry spans when di is enabled #13593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 274 ± 2 ms. The average import time from base is: 276 ± 2 ms. The import time difference between this PR and base is: -2.6 ± 0.1 ms. Import time breakdownThe following import paths have grown:
|
b6744e8
to
71f3dab
Compare
711df1e
to
5fe80f9
Compare
BenchmarksBenchmark execution time: 2025-06-10 17:37:07 Comparing candidate commit 4c12a8b in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 549 metrics, 3 unstable metrics. scenario:iastaspects-format_map_aspect
scenario:iastaspectsospath-ospathbasename_aspect
scenario:telemetryaddmetric-1-distribution-metric-1-times
scenario:telemetryaddmetric-1-gauge-metric-1-times
|
0bca853
to
976cfa6
Compare
bbd6881
to
0b98b5a
Compare
2ba2c4a
to
29125a9
Compare
287c115
to
0e52ca2
Compare
f21c3ed
to
00074f0
Compare
- Extract `SpanCodeOriginProcessorEntry` base class to handle entry span processing - Enable entry-only code origins when DI is enabled and span code origins aren't explicitly disabled - Refactor `SpanCodeOriginProcessor` to inherit from entry processor for code reuse - Update product lifecycle to conditionally enable entry vs full span processing Refs: DEBUG-3787
- Add is_enabled() method to ProductManager for consistent product state checking - Replace duplicate DI enablement logic in symbol_db/remoteconfig with centralized method - Update code_origin/span to use ProductManager.is_enabled() instead of direct config access - Add constants for better maintainability (CO_ENABLED, DI_PRODUCT_KEY)
00074f0
to
6781193
Compare
6781193
to
4c12a8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Enable code origins for entry spans when dynamic instrumentation is enabled.
This also breaks up code origin entry and exit spans into separate classes. This include a new processor for entry spans, updates to configuration and product management, and additional tests to ensure functionality and coverage.
Refs: DEBUG-3787
Checklist
Reviewer Checklist