-
Notifications
You must be signed in to change notification settings - Fork 443
refactor(profiling): remove legacy Python exporter and enable libdatadog exporter by default #13599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 271 ± 2 ms. The average import time from base is: 271 ± 2 ms. The import time difference between this PR and base is: -0.43 ± 0.09 ms. Import time breakdownThe following import paths have grown:
|
BenchmarksBenchmark execution time: 2025-06-06 21:06:14 Comparing candidate commit 6ef6e41 in PR branch Found 0 performance improvements and 4 performance regressions! Performance is the same for 553 metrics, 7 unstable metrics. scenario:iastaspects-upper_aspect
scenario:iastaspectsospath-ospathnormcase_aspect
scenario:iastaspectsospath-ospathsplitdrive_aspect
scenario:iastaspectsospath-ospathsplitext_aspect
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳 So much deleted code! This is pretty big so I may have missed something, but it seems like this is mostly just deleting the non-native exporter code. Left one non-blocking suggestion for the release note.
Removes python exporter and enable libdatadog exporter by default. Since stack v2 requires libdatadog exporter and it's the default mode, most customers would not be affected by this.
We are dropping 32-bit Linux support for profiling, but this can be added back once profiling depends on libdatadog via Rust bindings using PyO3.
Checklist
Reviewer Checklist