-
Notifications
You must be signed in to change notification settings - Fork 15
[crashtracking] upload to both telemetry intake and errors intake #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
BenchmarksComparisonBenchmark execution time: 2025-10-20 13:05:53 Comparing candidate commit d8a46d6 in PR branch Found 13 performance improvements and 10 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:benching string interning on wordpress profile
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number/x371413321323331
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/x371413321323331
scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...
scenario:normalization/normalize_name/normalize_name/good
scenario:normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...
scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
BaselineOmitted due to size. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
+ Coverage 71.97% 72.10% +0.12%
==========================================
Files 356 357 +1
Lines 56787 57483 +696
==========================================
+ Hits 40874 41448 +574
- Misses 15913 16035 +122
🚀 New features to boost your workflow:
|
|
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
7a55094
to
d42530c
Compare
74a5f22
to
9e55d5f
Compare
f1a953b
to
9ee8161
Compare
fca11ec
to
af27f4b
Compare
pub const DEFAULT_DD_SITE: &str = "datad0g.com"; | ||
pub const PROD_ERRORS_INTAKE_SUBDOMAIN: &str = "event-platform-intake"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are provisional for testing, let's not forget to change them later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we should default to prod, per todays meeting. It will get overwritten in staging tracers anyways
c750e71
to
5ff0588
Compare
e1cda96
to
12c1fec
Compare
23cc5f8
to
d8a46d6
Compare
TODOs:
|
What does this PR do?
With the new Errors intake, we want to support dual uploads to Errors intake and the current telemetry intake
Motivation
What inspired you to submit this pull request?
Additional Notes
Errors Intake endpoints and conditions; this was largely follows how
Telemetry
handlesCrashInfo
uploadsHow to test the change?
Unit tests
Run a tracer that points to the latest commit on this PR for libdatadog locally and crash a program
https://dd.datad0g.com/error-tracking?query=service%3Atest_app&fromUser=false&order=first_seen&refresh_mode=sliding&source=all&from_ts=1759843044695&to_ts=1760447844695&live=true