feat: update functions samples #10197
Conversation
product-auto-label
bot
added
samples
Summary of ChangesHello @maigovannon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Java compiler version for several function samples from Java 11 to Java 21. The primary purpose is to modernize the build configurations for these samples, ensuring they leverage the latest LTS features and maintain compatibility with contemporary Java development environments. This update affects the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Java compiler source and target versions from 11 to 21 for two function samples. The changes in the pom.xml files are correct. I've added a couple of suggestions to improve maintainability by using a property for the Java version, which is a common best practice in Maven projects. This will make future version updates simpler and less prone to error.
| <functionTarget>functions.SubscribeToTopic</functionTarget> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> |
There was a problem hiding this comment.
I get why you would add this but I'm not sure we should be adding this to the sample code. We want to illustrate using the Google Cloud Run function with Pub/Sub with a minimal example. This feels like it's adding complexity.
There was a problem hiding this comment.
This was actually needed to make mvn clean verify work properly. Without this, it fails.
| <properties> | ||
| <maven.compiler.target>11</maven.compiler.target> | ||
| <maven.compiler.source>11</maven.compiler.source> | ||
| <maven.compiler.target>21</maven.compiler.target> |
There was a problem hiding this comment.
We generally do not have samples for every run time in Functions. Java 11 is the minimum required runtime https://docs.cloud.google.com/run/docs/runtimes/java and that's why this is 11 currently. If y'all are thinking to move to latest supported (non-preview) that's fine, but it would be helpful to know that's the intent here. We should not have duplicate samples showing the basic usecase.
There was a problem hiding this comment.
Java11 is actually no longer supoprted and was decommissioned on 10/31: https://docs.cloud.google.com/run/docs/runtime-support#java
Description
Creating Java25 doc samples for Cloud Run Functions and updating some of the existing ones to Java21. These are forked changes from #10193
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only