-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(deps): update dependency google/cloud-datastore to v2 #2172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency google/cloud-datastore to v2 #2172
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the google/cloud-datastore dependency to v2.0.0, a major version upgrade. While the change itself is simple, it's only applied to the datastore/api sample. Other samples in this repository, datastore/quickstart and datastore/tutorial, still depend on v1.x. This inconsistency is a significant maintainability concern. I've added a comment recommending that all samples be updated to use the new major version of the dependency to ensure consistency and avoid potential conflicts.
| { | ||
| "require": { | ||
| "google/cloud-datastore": "^1.2" | ||
| "google/cloud-datastore": "^2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating to a new major version (v2.0) is a significant change. To ensure consistency across the samples and prevent potential maintenance issues, this dependency should be updated in all relevant composer.json files within this repository. Currently, datastore/quickstart/composer.json and datastore/tutorial/composer.json still point to ^1.2. It's best practice to upgrade all related samples together in a single pull request.
bshaffer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ran tests locally and they passed
This PR contains the following updates:
^1.2->^2.0Release Notes
googleapis/google-cloud-php-datastore (google/cloud-datastore)
v2.0.0: google/cloud-datastore v2.0.0Compare Source
Bug Fixes
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.