Removed method that causes exception #1949
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull from upstream
Removed unnecessary method (?) that causes exception when following the endpoints tutorial here: https://cloud.google.com/endpoints/docs/frameworks/python/get-started-frameworks-python#generating_the_openapi_document
googlebot
added
the
cla: yes
Contributor
|
Looks like we took so long to approve / resolve that master has drifted from your source branch (sorry about that!). Can you resolve the conflicts and we'll take another look. |
gguuss
suggested changes
Aug 13, 2019
Contributor
gguuss
left a comment
gguuss
left a comment
There was a problem hiding this comment.
Resolve conflicts with master and we can move forward on getting this in.
Contributor
|
from gguuss: I'd say go ahead and close <== Doing cloud samples issue rotation. It looks like the (non-googler) never responded to your comments in July/Aug. Can we close it. Your call? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary method (?) that causes exception when following the endpoints tutorial here: https://cloud.google.com/endpoints/docs/frameworks/python/get-started-frameworks-python#generating_the_openapi_document
If I don't remove this method, he error that I get when following the tutorial is:
endpoints.api_exceptions.ApiConfigurationError: audiences must be a dict when third-party issuers (auth0, firebase, etc) are in use.