Skip to content

Conversation

@aihgii
Copy link
Contributor

@aihgii aihgii commented Mar 29, 2021

Description

Fixes #5583

This sample uses Cloud Channel API.

Several new variables were added to testing/test-env.tmpl.sh with CHANNEL prefix.

Checklist

@aihgii aihgii requested a review from a team as a code owner March 29, 2021 19:09
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2021
@snippet-bot
Copy link

snippet-bot bot commented Mar 29, 2021

Here is the summary of changes.

You are about to add 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 29, 2021
@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2021
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a separate PR for the CODEOWNERS change so that the new code owner can be assigned to review this PR on that's merged.

@aihgii aihgii force-pushed the master branch 2 times, most recently from 8ad7e8e to 688fb59 Compare March 29, 2021 23:50
aihgii added a commit to aihgii/python-docs-samples that referenced this pull request Mar 30, 2021
engelke pushed a commit that referenced this pull request Mar 30, 2021
Refers #5583 accordingly [this](#5593 (review)) comment.

Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
@aihgii aihgii requested a review from engelke March 30, 2021 17:27
@tmatsuo
Copy link
Contributor

tmatsuo commented Mar 31, 2021

@aihgii

The snippet-bot will be happy when you use region tags with channel_ prefix. Also, maybe you should use underscore and lowercase for python samples. Most of the python samples are using that style.

For example, channel_get_admin_sdk_customer_id instead of getAdminSDKCustomerId, etc etc.

@aihgii
Copy link
Contributor Author

aihgii commented Mar 31, 2021

@tmatsuo

Updated, please review.

@engelke engelke removed their assignment Mar 31, 2021
assert "=== Selected offer" in out
assert "=== Created customer" in out
assert "=== Provisioned cloud identity" in out
assert "=== Created entitlement" in out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid that these asserts may pass even when some of the API call returns unexpected results?

export CHANNEL_RESELLER_ACCOUNT_ID=
export CHANNEL_RESELLER_ADMIN_USER=
export CHANNEL_CUSTOMER_PARENT_DOMAIN=
export CHANNEL_JSON_KEY_FILE=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add these values to our secret in secret manager for CI builds on Kokoro?

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 1, 2021
@tmatsuo tmatsuo added the snippet-bot:force-run Force snippet-bot runs its logic label May 20, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label May 20, 2021
@tmatsuo tmatsuo added the snippet-bot:force-run Force snippet-bot runs its logic label Jun 1, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jun 1, 2021
@engelke engelke removed their request for review June 29, 2021 16:37
@parthea
Copy link
Collaborator

parthea commented Aug 14, 2021

Hi @aihgii, I'm going to close this PR as the linked issue is closed but please feel free to re-open it.

@parthea parthea closed this Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Google Workspace end-to-end provisioning using Cloud Channel API examples

5 participants