-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Add Workspace provisioning using Channel API examples #5593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
engelke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a separate PR for the CODEOWNERS change so that the new code owner can be assigned to review this PR on that's merged.
8ad7e8e to
688fb59
Compare
Refers GoogleCloudPlatform#5583 accordingly [this](GoogleCloudPlatform#5593 (review)) comment.
Refers #5583 accordingly [this](#5593 (review)) comment. Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
|
The snippet-bot will be happy when you use region tags with For example, |
|
Updated, please review. |
| assert "=== Selected offer" in out | ||
| assert "=== Created customer" in out | ||
| assert "=== Provisioned cloud identity" in out | ||
| assert "=== Created entitlement" in out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid that these asserts may pass even when some of the API call returns unexpected results?
| export CHANNEL_RESELLER_ACCOUNT_ID= | ||
| export CHANNEL_RESELLER_ADMIN_USER= | ||
| export CHANNEL_CUSTOMER_PARENT_DOMAIN= | ||
| export CHANNEL_JSON_KEY_FILE= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add these values to our secret in secret manager for CI builds on Kokoro?
|
Hi @aihgii, I'm going to close this PR as the linked issue is closed but please feel free to re-open it. |
Description
Fixes #5583
This sample uses Cloud Channel API.
Several new variables were added to testing/test-env.tmpl.sh with CHANNEL prefix.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)