-
Notifications
You must be signed in to change notification settings - Fork 160
[input-group]: scope theme styles #15733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
desig9stein
wants to merge
11
commits into
simeonoff/scoped-styles
Choose a base branch
from
mpopov/scoped-styles/input-group
base: simeonoff/scoped-styles
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[input-group]: scope theme styles #15733
desig9stein
wants to merge
11
commits into
simeonoff/scoped-styles
from
mpopov/scoped-styles/input-group
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adding styles for material box(input,textarea,select and combo).
- Removing the logic for themes inside the .ts file, removing all classes related to specific themes. - Updating the showcase sample - wrapping the label theme in base layer
- modify the input group template - disabled typography - fix some layout issues - move more styles to base - update wc version and add file type input in the sample
Add clear icon colors in file type input.
also update the showcase sample to add remove the hint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
combo
🛠️ status: in-development
Issues and PRs with active development on them
input
input-group
select
Select component
✨ themes
styling
textarea
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15627
Additional information (check all that apply):
Checklist:
feature/README.MD
updates for the feature docsREADME.MD
CHANGELOG.MD
updates for newly added functionalityng update
migrations for the breaking changes (migrations guidelines)