Remove unnecessary (?) reload to avoid a Safari race condition #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this just in the page auth flow? Do you know if the storage is also flakey with the window.close() being called on popup auth flow? Could you remove the changes to |
tuomassalo
added a commit
to tuomassalo/hello.js
that referenced
this pull request
Apr 13, 2017
|
I encountered this error within page auth flow. I haven't investigated popup auth flow. Closing this in favor of #490. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a
location.assign(...)to ahistory.replaceState(...)in order to avoid an unnecessary (?) full page reload, in case we just want to remove the hash part, eg.#access_token=....This fixes a problem we ran into: Safari (macOS) would sometimes execute
location.assign()before the asynchronous code that actually saves the access token to storage would finish.Yes, sometimes. It seems to be a timing issue that happens when the actual page loads slowly.
This Works For Me™, and I apologize for not having time to build a test case. Also, my knowledge of all this stuff is quite limited, so I'm not claiming this PR to be a trouble-free. I'm PR'ing FYI anyway.