Skip to content

Flexvar #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Flexvar #96

wants to merge 4 commits into from

Conversation

malihass
Copy link
Collaborator

@malihass malihass commented May 3, 2025 •
edited
Loading

Fix #95

  • Make sure that Thermo properties are consistent across cases and resolve conflicts
  • Add comment in yaml files explaining where the properties (Especially WC and He coefficient) are from (@mjrahimi)
  • Make sure that Henry properties are consistent across cases and resolve conflicts
  • Make sure that dependencies are correctly handled when automating the global var writing (checked for disengagement only, but needs to be checked for all cases)
  • Some inputs are inconsistent, (mflowrate vs mflowrategas)

@malihass malihass marked this pull request as draft May 3, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Central location for Henry's constants
1 participant
@malihass