Skip to content

Fix for 11016; Set correct water flow rate of companion cooling coils for WAHP applications using the AirloopHVAC:UnitarySystem #11017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix for 11016; Set correct water flow rate of companion cooling coils for WAHP applications using the AirloopHVAC:UnitarySystem #11017

wants to merge 1 commit into from

Conversation

lymereJ
Copy link
Collaborator

@lymereJ lymereJ commented Apr 1, 2025 •
edited
Loading

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@lymereJ lymereJ added the Defect Includes code to repair a defect in EnergyPlus label Apr 1, 2025
@lymereJ
Copy link
Collaborator Author

lymereJ commented Apr 1, 2025

Water flow rate for the defect file ...

... With the current develop:
current_develop

... With this branch:
with_fix

lymereJ
lymereJ commented Apr 1, 2025
View reviewed changes
Copy link
Collaborator Author

@lymereJ lymereJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walkthrough:

src/EnergyPlus/WaterToAirHeatPumpSimple.cc
Comment on lines -2960 to +2970
if (simpleWatertoAirHP.WAHPType == WatertoAirHP::Heating) {
PlantUtilities::RegisterPlantCompDesignFlow(
state, simpleWatertoAirHP.WaterInletNodeNum, 0.5 * simpleWatertoAirHP.RatedWaterVolFlowRate);
if (simpleWatertoAirHP.CompanionCoolingCoilNum > 0) {
auto &companionCoolingCoil(state.dataWaterToAirHeatPumpSimple->SimpleWatertoAirHP(simpleWatertoAirHP.CompanionCoolingCoilNum));
if (simpleWatertoAirHP.CompanionCoolingCoilNum > 0) {
auto &companionCoolingCoil(state.dataWaterToAirHeatPumpSimple->SimpleWatertoAirHP(simpleWatertoAirHP.CompanionCoolingCoilNum));
if (companionCoolingCoil.RatedWaterVolFlowRate > simpleWatertoAirHP.RatedWaterVolFlowRate) {
simpleWatertoAirHP.RatedWaterVolFlowRate = companionCoolingCoil.RatedWaterVolFlowRate;
} else {
companionCoolingCoil.RatedWaterVolFlowRate = simpleWatertoAirHP.RatedWaterVolFlowRate;
PlantUtilities::RegisterPlantCompDesignFlow(
state, companionCoolingCoil.WaterInletNodeNum, 0.5 * simpleWatertoAirHP.RatedWaterVolFlowRate);
}
} else if (simpleWatertoAirHP.WAHPType == WatertoAirHP::Cooling) {
PlantUtilities::RegisterPlantCompDesignFlow(
state, simpleWatertoAirHP.WaterInletNodeNum, 0.5 * simpleWatertoAirHP.RatedWaterVolFlowRate);
}
PlantUtilities::RegisterPlantCompDesignFlow(state, simpleWatertoAirHP.WaterInletNodeNum, 0.5 * simpleWatertoAirHP.RatedWaterVolFlowRate);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This routine is called sequentially for each coil, so set the flow rate of each coil based on the larger of the two companion coils.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is off topic but if the Sizing:Plant object uses different delta T's shouldn't the flow rate in each operating mode be different (i.e., to actually operate at the Sizing:Plant delta T specified)? This is of course outside the scope of this issue but I think it's important to think of things like that. I guess it would be good to check manufacturers data to see if different water flow rates are ever possible or if 2-speed pumps are ever used. Using the same flow rate for cooling and heating does seem like the right choice. Although I do wonder if there are times when the first coil would post it's result to the eio before the companion coil got a chance to update the water flow rate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could very well be wrong but I don't think that this issue could arise. Stepping through the debugger I see that, when we have companion coils, because the cooling coil is always evaluated first and its final capacity is only fully determined after the heating coil has been sized, I think that the process to output the flow to the EIO file is only done then (meaning after both coils have been sized) and only once.

On a different note, I see comments in the block of code above this one related to the system capacity used to determined the flow rate. I think these comments are valid: we're currently using the evaporator capacity but we should use the condenser capacity. Should a different PR be created to address these?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create a different PR for changing the condenser flow sizing method.

@lymereJ lymereJ added this to the EnergyPlus 25.2 IO Freeze milestone Apr 1, 2025
@lymereJ lymereJ changed the title Fix for; Set correct water flow rate of companion cooling coils for WAHP applications using the AirloopHVAC:UnitarySystem Fix for 11016; Set correct water flow rate of companion cooling coils for WAHP applications using the AirloopHVAC:UnitarySystem Apr 1, 2025
@Myoldmopar Myoldmopar self-assigned this Apr 9, 2025
@nrel-bot-2
Copy link

@Myoldmopar @lymereJ @Myoldmopar it has been 29 days since this pull request was last updated.

@nrel-bot-2c
Copy link

@Myoldmopar @lymereJ @Myoldmopar it has been 35 days since this pull request was last updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rraustad rraustad rraustad left review comments

Assignees

@Myoldmopar Myoldmopar

Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Milestone
EnergyPlus 25.2 IO Freeze
Development

Successfully merging this pull request may close these issues.

No water flow rate during cooling operation when heating coil water flow rate is hardsized
5 participants
@lymereJ @nrel-bot-2 @nrel-bot-2c @rraustad @Myoldmopar